859048 - Add a way to get the IP address and IP version (v4 or v6) that was used to retrieve a given resource

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Comment 1

[Victor Porof [:vporof][:vp]]

"This would be hugely helpful when dealing with sites that are backed by more than one server."

Comment 2

[Victor Porof [:vporof][:vp]]

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

Comment 5

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Add Remote Address to the network tab headers panel

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8569258 [details] [diff] [review]
Add Remote Address to the network tab headers panel

Review of attachment 8569258 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but we will need a test for this as well. You can probably just add some checks into browser_net_simple-request-details.js.

::: browser/devtools/netmonitor/netmonitor.xul
@@ +293,5 @@
>              <tabpanels flex="1">
>                <tabpanel id="headers-tabpanel"
>                          class="tabpanel-content">
>                  <vbox flex="1">
> +                  <hbox id="headers-summary-address"

I think this should appear beneath the request URL and method, which are the most important things about a request.

::: browser/locales/en-US/chrome/browser/devtools/netmonitor.dtd
@@ +135,5 @@
>  <!-- LOCALIZATION NOTE (debuggerUI.panesButton.tooltip): This is the tooltip for
>    -  the button that toggles the panes visible or hidden in the netmonitor UI. -->
>  <!ENTITY netmonitorUI.panesButton.tooltip "Toggle network info">
>  
> +<!-- LOCALIZATION NOTE (debuggerUI.summary.address): This is the label displayed

netmonitorUI, not debuggerUI. Could you also fix the other comments while you are here?

Comment 7

[Ian Moody [:Kwan] (UTC+1)]

(In reply to Panos Astithas [:past] from comment #6)
> Looks good, but we will need a test for this as well. You can probably just
> add some checks into browser_net_simple-request-details.js.
Cool, I'll take a look.

> I think this should appear beneath the request URL and method, which are the
> most important things about a request.
Can do.  I just copied Chrome's position for getting it up and running, very open to feedback on UI.

> netmonitorUI, not debuggerUI. Could you also fix the other comments while
> you are here?
Sure.

I made a couple of small changes since in my current version already:
+ "Remote Address" -> "Remote address" to match the rest of the labels
+ add [] around the address if indexOf(":") != -1, to distinguish IPv6 addresses from the port number.

Also, I notice bug 663151 which was duped to this was for adding it to the webconsole's net panel, shall I include that too?  (I already have a patch)

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

We don't really care about the console's net panel and want to kill it as soon as possible (bug 861335). I wouldn't worry about it.

Comment 9

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Add Remote Address to the network tab headers panel v1.2

+change string casing to match rest of panel
+IPv6 addrs now get [] around them
+test added (is the hardcoded ip:port okay?  I'm not sure what else it'd ever be/how we'd calculate it)
+output moved below method
+s/debuggerUI/netmonitorUI/g in .dtd (all 40+ of them)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=092d6bfed28e

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8569814 [details] [diff] [review]
Add Remote Address to the network tab headers panel v1.2

Review of attachment 8569814 [details] [diff] [review]:
-----------------------------------------------------------------

If try is ok with the address and port number, I'm fine too.

Comment 11

[Ian Moody [:Kwan] (UTC+1)]

try run in comment 9 all green (with the exception of an extremely tardy Windows 8 x64 debug M(dt3))

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/d97e4aee9a3a

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d97e4aee9a3a

Comment 14

[Will Bamberg [:wbamberg]]

Does this cover it?
-> https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor#Headers

Comment 15

[Victor Porof [:vporof][:vp]]

Looks good!