859055 - Display JSON as plain text when encountering errors when parsing

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Victor Porof [:vporof][:vp]]

Sometimes a server may specify a json response content type, but the payload could be malformed. In that case, errors encountered when parsing JSON could be shown in the UI. Right now nothing is displayed (not even the response text!).

Comment 1

[Victor Porof [:vporof][:vp]]

Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.

Comment 2

[Victor Porof [:vporof][:vp]]

Aside from the "Yo, you have an error" message, the response should be shown as plain text in a source editor.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 4

[Victor Porof [:vporof][:vp]]

Attachment: v2

Forgot to add the "Yo, you have an error" message in the Response tab. Now it's in. Enjoy. It's pretty.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: looks like this

Comment 6

[Victor Porof [:vporof][:vp]]

Green: https://tbpl.mozilla.org/?tree=Try&rev=3d4b4fa8d413

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 759138 [details] [diff] [review]
v2

Review of attachment 759138 [details] [diff] [review]:
-----------------------------------------------------------------

hot.

::: browser/devtools/netmonitor/netmonitor-view.js
@@ +1647,5 @@
> +          let infoHeader = $("#response-content-info-header");
> +          infoHeader.setAttribute("value", parsingError.message);
> +          infoHeader.setAttribute("tooltiptext", parsingError.toString());
> +          infoHeader.hidden = false;
> +        }

I think I've stared at this long enough.

::: browser/devtools/netmonitor/test/browser_net_json-malformed.js
@@ +63,5 @@
> +          "The mode active in the source editor is incorrect.");
> +
> +        teardown(aMonitor).then(finish);
> +      });
> +    });

yarp!

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/6f1899c6e4e0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f1899c6e4e0