Created attachment 734374 [details] demonstration of the problem If there are closing parentheses after the closing tag of <span dir="auto">, they are shown on the wrong side of the word. See the attached HMTL file.
Regression range: m-c good=2011-10-19 bad=2011-10-20 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9fa62f76f1cf&tochange=311fdb9b38b7 Suspected bug: Jonathan Kew — bug 694986 - trailing bracket misplaced in LTR language names when language-picker UI is displayed RTL. r=mfinkle
Keywords: regression, rtl
Version: 20 Branch → 10 Branch
Bug 694986 touched -only- mobile JS code in mobile/chrome/content/localePicker.js, which was specific to the XUL fennec UI, so it's never been part of desktop Firefox, and isn't even present on mobile any longer. (See https://hg.mozilla.org/mozilla-central/rev/387f388bca1f.) So I don't think that can have caused the issue here.
No, this is certainly caused by an error in bug 613149
Created attachment 734631 [details] [diff] [review] Patch This was a very silly mistake :(
Assignee: nobody → smontagu
Attachment #734631 - Flags: review?(roc)
The issue isn't with dir=auto as such, but with any inline element with unicode-bidi: -moz-isolate.
Summary: broken handling of parentheses near dir=auto → broken handling of parentheses near inlines with unicode-bidi: isolate
Attachment #734631 - Flags: review?(roc) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Comment on attachment 734631 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 613149, and exposed in more contexts by bug 548206 User impact if declined: regressions in reordering of bidirectional text -- in particular it will appear as if the new bidi features of isolation and autodirection make reordering less accurate instead of more accurate as intended Testing completed (on m-c, etc.): baked on m-c since 2013-04-08 Risk to taking this patch (and alternatives if risky): Minimal. String or IDL/UUID changes made by this patch: None
Attachment #734631 - Flags: approval-mozilla-aurora?
Attachment #734631 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox22: --- → fixed
status-firefox23: --- → fixed
Target Milestone: mozilla23 → ---
Backed out on beta to fix bug 870794. https://hg.mozilla.org/releases/mozilla-beta/rev/366114b62435
You need to log in before you can comment on or make changes to this bug.