Closed Bug 859135 Opened 7 years ago Closed 6 years ago

Hovering over a request with an image response should show a popup displaying that image

Categories

(DevTools :: Netmonitor, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 30

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file, 2 obsolete files)

No description provided.
Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.
Component: Developer Tools → Developer Tools: Netmonitor
Summary: [netmonitor] Hovering over a request with an image response should show a popup displaying that image → Hovering over a request with an image response should show a popup displaying that image
Priority: -- → P2
How would this be reconciled with the tooltip text that pops up when one hovers over the various cells of the request line? You wouldn't want them to overlap, and that might be very hard to guarantee on all platforms. I guess on some platforms, you can put images in tooltips too, but is that possible on all platforms? It doesn't really make sense to show the image in every tooltip of every cell when every tooltip has different textual information. On the other hand, if it's only shown in the tooltip of one of the cells, that makes it harder for users to discover its existence.
Flags: needinfo?(vporof)
I think this is reasonable and a huge timesaver for people who developed such muscle memory. Implementation is easy and cross platform if done in XUL (although xul:panels are quite buggy). My suggestion is having this panel shown when hovering every request in the menu (but not when hovering the waterfall section).

Rob, what do you think about this?
Flags: needinfo?(vporof) → needinfo?(rcampbell)
(In reply to Victor Porof [:vp] from comment #3)
> I think this is reasonable and a huge timesaver for people who developed
> such muscle memory. Implementation is easy and cross platform if done in XUL
> (although xul:panels are quite buggy). My suggestion is having this panel
> shown when hovering every request in the menu (but not when hovering the
> waterfall section).
> 
> Rob, what do you think about this?

Totally do-able. Not sure what you mean by "hovering every request in the menu" though. The text columns in the table but not the graphical waterfall? If so, I say go for it.
Flags: needinfo?(rcampbell)
(In reply to Rob Campbell [:rc] (:robcee) from comment #4)
> 
> Totally do-able. Not sure what you mean by "hovering every request in the
> menu" though. The text columns in the table but not the graphical waterfall?

Yup!

> If so, I say go for it.

!
Sure.
See Also: → 765105
I think #874884 should be fixed before this. Maybe depends on? Or is it not such a priority?
(In reply to Greg Karz from comment #8)
> I think #874884 should be fixed before this. Maybe depends on? Or is it not
> such a priority?

It seems to me that neither bug needs to block work on the other.
I'd love it if bug 765105 offered us a reusable component or widget. I agree it's not entirely related to bug 874884.
Attached patch v1 wip (obsolete) — Splinter Review
Patrick, please have a quick glance over the changes in Tooltip.js. Thanks!
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8375525 - Flags: feedback?(pbrosset)
Comment on attachment 8375525 [details] [diff] [review]
v1 wip

Review of attachment 8375525 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to do this recently but since I didn't have an immediate use for it, I didn't
+1 for this!
Attachment #8375525 - Flags: feedback?(pbrosset) → feedback+
Depends on: 859136
Attached patch v2 (obsolete) — Splinter Review
Attachment #8375525 - Attachment is obsolete: true
Attachment #8375620 - Flags: review?(rcampbell)
Attached patch v3Splinter Review
Found a bug where tooltips wouldn't be shown if the contents of the requests table would be sorted or filtered after a navigation. Fixed, added more assertions in tests.
Attachment #8375620 - Attachment is obsolete: true
Attachment #8375620 - Flags: review?(rcampbell)
Attachment #8375743 - Flags: review?(rcampbell)
Attachment #8375743 - Flags: review?(rcampbell) → review+
https://hg.mozilla.org/mozilla-central/rev/55252570e8d6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Keywords: verifyme
Whiteboard: [qa+]
I was able to confirm the fix for this issue on Firefox 30 Beta 3 (Build ID: 20140508121358), using:
  * Windows 7 64-bit [1],
  * Ubuntu 12.04 32-bit [2],
  * Mac OS X 10.8.5 [3].

[1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0
[2] Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
[3] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:30.0) Gecko/20100101 Firefox/30.0
Status: RESOLVED → VERIFIED
Keywords: verifyme
Whiteboard: [qa+] → [qa!]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.