Import reftests in dom/imptests

RESOLVED FIXED in mozilla23

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Depends on: 866424
(Assignee)

Comment 1

5 years ago
Created attachment 742823 [details] [diff] [review]
Part a: Update importTestsuite.py to import reftests as well
Attachment #742823 - Flags: review?(jhammel)
(Assignee)

Comment 2

5 years ago
Created attachment 742824 [details] [diff] [review]
Part b: Import HTML's reftests

smontagu for the bidi-related ones, mounir for the others. Note that most of these are moves, as they already lived somewhere else in m-c.
Attachment #742824 - Flags: review?(mounir)
(Assignee)

Updated

5 years ago
Attachment #742824 - Flags: review?(smontagu)
(Assignee)

Comment 3

5 years ago
Created attachment 742825 [details] [diff] [review]
Part c: Run them

Haven't automated this for now, given the small number of dirs.
Attachment #742825 - Flags: review?(jhammel)
Comment on attachment 742824 [details] [diff] [review]
Part b: Import HTML's reftests

Review of attachment 742824 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the bidi tests. As far as I remember, none of the changes in the version that I checked in to layout/reftests/bidi/dirAuto are vital, and some of them may even be deleterious (e.g. adding dir to the <bdi>s in dir_auto-contained-bdi-L.html).
Attachment #742824 - Flags: review?(smontagu) → review+
Attachment #742824 - Flags: review?(mounir) → review+

Comment 5

5 years ago
Comment on attachment 742823 [details] [diff] [review]
Part a: Update importTestsuite.py to import reftests as well

Review of attachment 742823 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: dom/imptests/importTestsuite.py
@@ +110,4 @@
>          for mochitest in d["mochitests"]:
>              shutil.copy("%s/%s" % (sourcedir, mochitest), "%s/test_%s" % (destdir, mochitest))
> +        for reftest in sorted(reftestfiles):
> +            shutil.copy("%s/%s" % (sourcedir, reftest), "%s/%s" % (destdir, reftest))

it'd be nice to combine these loops into a two layer nested loop (but not impportant)
Attachment #742823 - Flags: review?(jhammel) → review+

Updated

5 years ago
Attachment #742825 - Flags: review?(jhammel) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 747401 [details] [diff] [review]
Part d: A few more
Attachment #747401 - Flags: review?(mounir)
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/abe0099bab0e
https://hg.mozilla.org/mozilla-central/rev/92e51876e67d
https://hg.mozilla.org/mozilla-central/rev/02f7faabdbd9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(Assignee)

Comment 8

5 years ago
Comment on attachment 747401 [details] [diff] [review]
Part d: A few more

Will do this in another bug.
Attachment #747401 - Attachment is obsolete: true
Attachment #747401 - Flags: review?(mounir)
You need to log in before you can comment on or make changes to this bug.