Null Media as a clip behaves incorrectly on the timeline

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: cade, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
STR:

1. Add "#t=,35" as a media clip, and then add it to the timeline as an event
2. Move it around, resize it however you please.

Expected: should behave like any other media clip.
Actual: It's size changes to values you did not set. eventually it's view can disappear altogether and it will have negative start values and massive end times ( >10 hours) I've also seen it affect the times of other media clips on the timeline.

We should just prevent the adding of null media clips completely, because they're useless.
agreed, you shouldn't be able to do that (though I don't think anyone would as it isn't exposed in the interface)
(Assignee)

Updated

6 years ago
Assignee: nobody → scott
(Assignee)

Comment 2

6 years ago
Some updated STRs:

1. drop a null media clip that is smaller than the main media's duration.
2. change the end time to be greater than the initial end time.

Expected: Enforce track event duration.
Actual: Crazy town.
(Reporter)

Comment 4

6 years ago
Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

nice, simple fix. Man, it's easy to get burned by data types in JS.

R+

Up to you if you think a second review is warranted.
Attachment #734626 - Flags: review?(chris) → review+
(Assignee)

Comment 5

6 years ago
Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

SR?
Attachment #734626 - Flags: review+ → review?(schranz.m)
Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

My only question is why we are allowing null media to be added as clips period. It doesn't have any use case as far as I can tell. I'm personally in favor of removing it completely from the getMetaData portion of the MediaUtil API.

Thoughts?
Attachment #734626 - Flags: review?(schranz.m)
Attachment #734626 - Flags: review+
Attachment #734626 - Flags: feedback?(scott)
(Assignee)

Comment 7

6 years ago
Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

I don't think it is worth worrying about it. It does no harm.

If you really want it gone, could we do it in a new ticket?

I would R+ it.
Attachment #734626 - Flags: feedback?(scott) → feedback?(schranz.m)
Comment on attachment 734626 [details]
https://github.com/mozilla/butter/pull/1655

Fine.

See #862348.
Attachment #734626 - Flags: feedback?(schranz.m) → feedback+
(Assignee)

Comment 9

6 years ago
Staged: https://github.com/mozilla/butter/commit/9fe07090cef5034f1a6e8fc29be9767a74568661
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.