Move Log Request and Response Bodies option to Net Monitor panel

NEW
Unassigned

Status

defect
P3
normal
6 years ago
11 months ago

People

(Reporter: rcampbell, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Need to move the option to log request and response bodies out of the console and into the network panel. Possibly enabled by default when viewing the network panel.
Moving into Developer Tools: Netmonitor component. Filter on NETMONITORAMA.
Component: Developer Tools → Developer Tools: Netmonitor
OS: Mac OS X → All
Hardware: x86 → All
Summary: [netmonitor] move Log Request and Response Bodies option to Net Monitor panel → Move Log Request and Response Bodies option to Net Monitor panel
Priority: -- → P3
I hope I'm not out of line but I wanted to register a comment on this change.

I feel like it would be somewhat out of place to move this option to the Network panel.  I can understand the logic of the move: it's network related, ergo it fits under the Network panel... but since this option controls what gets display in the Console panel it seems like it makes more sense to remain where it is.

As a web dev who uses Firefox day in and day out for my work, I do like the idea of setting that option on by default, assuming there's no performance implication to doing so (I haven't observed any, but I've never profiled it concretely)... I'm keeping an eye on bug 1064458, which is dealing with maintaining the state of that option between sessions.  Speaking from experience, there are many times where I need to capture bodies but I forget to flip the switch, so maintaining it between sessions is important for me... having it be on by default would solve my problem entirely... although, as that ticket talks about, a preference for it would be just as good, since I could then set it once and forget it.

In short, my vote (for whatever it may or may not be worth) would be to leave it where it is on the Console tab, but have it be on by default as suggested, and preferably add a preference to be able to change that by an end user if they wish.
(In reply to Frank W. Zammetti from comment #2)
> I feel like it would be somewhat out of place to move this option to the
> Network panel.  I can understand the logic of the move: it's network
> related, ergo it fits under the Network panel... but since this option
> controls what gets display in the Console panel it seems like it makes more
> sense to remain where it is.

After bug 861335 being closed, this statement is no longer valid. The option now only influences the display within the Network panel, so it should definitely be moved there.

Sebastian
One important detail that we were discussing on IRC yesterday is that when the network panel opens, it stores the bodies unconditionally. The console pref affects now the network request recording between the time the toolbox is opened and the network panel is opened/selected. I still think that this is a good tradeoff, as when people open the network panel they are likely to expect the entire request, but when they open the toolbox to visit the console or the inspector, they are less likely to be interested in the request bodies (whose recording does not come for free).

It may make more sense to move the option in the options panel (Common preferences) and reword it like "Always record network request and response bodies" with a more descriptive tooltip like "Record network request and response bodies even when other tools besides the network panel are selected".
(In reply to Panos Astithas [:past] from comment #4)
> One important detail that we were discussing on IRC yesterday is that when
> the network panel opens, it stores the bodies unconditionally. The console
> pref affects now the network request recording between the time the toolbox
> is opened and the network panel is opened/selected. I still think that this
> is a good tradeoff, as when people open the network panel they are likely to
> expect the entire request, but when they open the toolbox to visit the
> console or the inspector, they are less likely to be interested in the
> request bodies (whose recording does not come for free).

I agree with that.

> It may make more sense to move the option in the options panel (Common
> preferences) and reword it like "Always record network request and response
> bodies" with a more descriptive tooltip like "Record network request and
> response bodies even when other tools besides the network panel are
> selected".

Ok, but then the option should not have any influence on the bodies when you reload the page while you're at the Network panel. Currently when you have the option turned off, open the toolbox at the Console panel, then switch to the Network panel and reload the page, the bodies will stay empty. Please note the related bug 1206061.

Sebastian
See Also: → 1206061
I agree with what you said, but note that your STR in bug 1206061 comment 1 indicate reloading before switching to the network panel, which will cause the unconditional switch toggle I mentioned above.
Right, though the important point (which is not mentioned there, because it's irrelevant there) is that when you're reloading the page at step 4, you still won't see the bodies.

Sebastian
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.