859321 - Track events can get start values < 0

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Chris DeCairos (:cade)]

STR:

1. Add a track event (can even be a media clip)
2. Adjust event to start at 0 and end at the duration of the project
3. Start a drag on the event, try to move it further right - i.e. attempt to make it's end > duration
4. Drop it

Expected: the event shouldn't move/change (unless it's placed on a new layer)
Actual: the event gets a start time that's less than 0 seconds and an end time that's less than duration.

Looks like one of our calculations is over correcting by a few pixels somewhere.

Comment 1

[Scott [:thecount] Downe]

Matt, this is this still valid?

Comment 2

[Matthew Schranz [:mjschranz]]

It is.

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/82

Seemed better to just deal with it in this spot.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 769038 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/82

No way we can use any form of element.clientWidth here so we don't need to hard code in the border pixels?

https://developer.mozilla.org/en-US/docs/Web/API/element.clientWidth?redirectlocale=en-US&redirectslug=DOM%2Felement.clientWidth

Also, if you drag and drop to the left, you can get duration of the track event to be greater than the media's duration.

Finally, no way to stop the little movement it does when you drag it? It probably shouldn't be doing that either. That might actually be an even deeper cause to this. If the dragging limits are checking css elements with borders, this might happen.