85936 - gtkEmbed needs a facelift

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

gtkEmbed needs to exercise the features of a rudimentary browser. At the moment
it doesn't even do that.

Things to be sorted out:

1. Buttons for back, forward, stop, reload etc.
2. An address bar that updates after a location change
3. Handle prompts correctly via a prompt service
4. Handle PSM chrome based dialogs
5. Update title bar with document title required
6. Open new windows with the correct dimensions

Comment 1

[Adam Lock]

Attachment: First patch

Comment 2

[Adam Lock]

The first patch adds back, forward, stop, reload & go buttons and resizes the
browser area when the frame is resized.

Indentation has also been cleaned up.

Comment 3

[arik devens]

i would like to work on a major facelift for gtkembed if noone is doing it...

Comment 4

[Adam Lock]

Arik, feel free to work on gtkEmbed and take this bug but please talk to Tracy
Walker in QA to see what they need.

You may like to apply my first patch which fixes some of the more gross UI
deficiencies in gtkEmbed.

Comment 5

[Adam Lock]

Reassigning

Comment 6

[Chris McAfee]

Also note that galeon (http://galeon.sourceforge.net) might
be a good example of a gtk embedded project that we could
look at.  The code is LGPL, so we need to be careful about
borrowing code; usage of API's is probably the main thing here.

Comment 7

[Christopher Blizzard (:blizzard)]

Guys, TestGtkEmbed is very nice and is pretty complete, feature wise.

Comment 8

[Adam Lock]

I'm not suggesting we write a complete browser, just make gtkEmbed suck less.

Comment 9

[Chris McAfee]

I didn't know about TestGtkEmbed, I don't think it's documented anywhere.
Why do we have two test apps?  TestGtkEmbed seems to suck less than
gtkEmbed.

Comment 10

[Adam Lock]

TestGtkEmbed is built around the gtk browser widget, introducing an extra layer
of complexity. The gtkEmbed application directly uses the embedding API so it's
more suitable for QA.

Comment 11

[Christopher Blizzard (:blizzard)]

Well, in order to get everything "right" you're going to have to implement most
of the stuff that's already in the embedding widget anyway.

Comment 12

[Judson Valeski]

the idea is that gtkEmbed provides a stripped down linux implementation using
only gtk (no other layers).

Comment 13

[Chris McAfee]

I agree with blizzard.  gtkEmbed is gonna have to go
hack up window sizing and focus stuff, stuff that the
GtkMozEmbed widget already does.  Why not start there?
Think of it as a layer of sanity rather than a layer
of complexity.  If I was gonna go fix gtkEmbed today,
I'd go steal code from TestGtkEmbed.  Why not?  It works.
The widget has a good class structure started, it makes sense,
let's use it.  If the widget is too big or complicated,
I'd like to hear why before we start down the fix-gtkEmbed road.

Comment 14

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.