859370 - Please deploy butter tag v1.0.30

Status: RESOLVED FIXED

(Webmaker Graveyard :: DevOps, defect)

Description

[Ross Bruniges [:boozeniges]]

https://github.com/mozilla/butter/tree/v1.0.29 - all packaged up like a sweet parcel :)

Comment 2

[Jon Buckley]

Adding `description` varchar(255) DEFAULT NULL to the Projects table

Comment 3

[JP Schneider :jp]

This deployment requires a schema change of the butter.Projects table before the code lands.
I closed the other ticket as a dupe, as our process will be to funnel all changes required for a deploy into a single deploy ticket(ie, migrations, schema changes, system configuration changes, builder changes).

This will help when troubleshooting, and prevent a spiderweb of tickets to crawl during times of woe.

Comment 4

[JP Schneider :jp]

The migration:  ALTER TABLE butter.Projects ADD description VARCHAR(255) DEFAULT NULL;

I'm cloning last nights snapshot of production, and we will try this schema change there for timing.  Then, we will decide if OSC is recommended based on that timing

Comment 5

[JP Schneider :jp]

Migration has been run normally on the migration test clone of production:

ALTER TABLE butter.Projects ADD COLUMN description VARCHAR(255) DEFAULT NULL; 19710 row(s) affected Records: 19710  Duplicates: 0  Warnings: 0
33.729 sec

When we push this to production, do we mind if things are locked for 37 seconds, causing problems for anyone saving?  Should we do this osc?

Comment 6

[JP Schneider :jp]

In the meantime, running this on staging, and pushing the v1.0.29 tag.

Comment 7

[JP Schneider :jp]

v1.0.29 is in staging!

Deployment Report: https://rpm.newrelic.com/accounts/255689/applications/2709234/deployments/596465

[ec2-107-20-91-139.compute-1.amazonaws.com] out: Version: 1.0.29-1
[ec2-107-20-91-139.compute-1.amazonaws.com] out: < HTTP/1.1 200 OK

Comment 8

[Jon Buckley]

Found a bad performance bug in v1.0.29, so I need to stage bug 859483 and then tag v1.0.30.

Comment 9

[JP Schneider :jp]

BUTTER STAGING-ENV, YOU HAD ONE JOB...and you did it!! :)

Comment 10

[Jon Buckley]

Alright, tagged. Deploy to staging!

Comment 11

[JP Schneider :jp]

v1.0.30 is in staging!

Deployment Report: https://rpm.newrelic.com/accounts/255689/applications/2709234/deployments/596713

[ec2-107-20-91-139.compute-1.amazonaws.com] out: Version: 1.0.30-1
[ec2-107-20-91-139.compute-1.amazonaws.com] out: < HTTP/1.1 200 OK

Comment 12

[JP Schneider :jp]

I am working on trimming down the build script by removing ./.git* and ./external/popcorn-js/test/ before the packaging.

Comment 13

[JP Schneider :jp]

Jbuck gave the +1 to go to prod.
This is now in production!

Deployment Report:  https://rpm.newrelic.com/accounts/255689/applications/2703518/deployments/596765#tab-view_deployment=change_report&sort=4%2C1

[ec2-75-101-190-166.compute-1.amazonaws.com] out: Version: 1.0.30-1
[ec2-54-234-116-12.compute-1.amazonaws.com] out: Version: 1.0.30-1
[ec2-54-242-160-3.compute-1.amazonaws.com] out: Version: 1.0.30-1
[ec2-50-17-32-123.compute-1.amazonaws.com] out: Version: 1.0.30-1
[ec2-75-101-190-166.compute-1.amazonaws.com] out: < HTTP/1.1 200 OK
< HTTP/1.1 200 OK
[ec2-54-242-160-3.compute-1.amazonaws.com] out: < HTTP/1.1 200 OK
[ec2-50-17-32-123.compute-1.amazonaws.com] out: < HTTP/1.1 200 OK


I first ran the migration manually, it locked for 18.647 seconds
--
16:22:38	ALTER TABLE butter.Projects ADD COLUMN description VARCHAR(255) DEFAULT NULL	19807 row(s) affected Records: 19807  Duplicates: 0  Warnings: 0	18.647 

--
I then pushed the code with a 60 second roll between nodes revving, and all seems to be set.