[tr] Search engine setup for Firefox Mobile for Turkish.

RESOLVED FIXED in mozilla21

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gueroJeff, Assigned: Milos)

Tracking

({productization})

unspecified
mozilla21
x86
Mac OS X
productization

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We want to ship Firefox Mobile with a good list of search engines for Turkish.

We're going to work towards this in three phases. First, the localization team and the l10n drivers will look at the market for the language and come up with a good set of search providers. Selim, we'll need your input on this, the guidelines for making recommendations are on <https://wiki.mozilla.org/L10n:Mobile/Productization>.

For en-US, we currently use this set, to which we can fall back in the case of lacking localized alternatives:

> Google (mobile version), Amazon, Twitter, Wikipedia (slightly different to desktop, 32x32 icon)

Once we decide to use a particular search engine (and we test it on a mobile device), l10n drivers will contact the owner and ask for permission, and for specifics like proper search flags. Selim, we'll likely need your help to at least get the contact information.

For search engines that we already ship with on desktop and that you would like to include in mobile as well, the permission is not needed. Consider using a mobile version of the engine if one is available. Also, please make yourself familiar with instructions regarding the <Description/> element at <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions>.

Once we have a specification on what the search engines for Turkish should look like, Milos and the localization team will work on an implementation on that. Milos will create and attach patches for the desired changes and get them reviewed. After a successful review, Milos will land them. Selim, if you're interested, you could create the patches, too. You'd ask Milos for review on those before landing.

Please don't commit any modifications in browser/searchplugins to the hg repository without a patch reviewed by Milos, Stas, Axel or someone else appointed by the l10n drivers. The data here is sensitive to users and our search partners, thus the extra care here.

The Turkish team and Milos will be driving this bug to completion.

Comment 1

5 years ago
We made our decision upon Google, Yandex, Twitter, Wikipedia.

Google, Yandex, and Wikipedia are already available on desktop.

I'm guessing Google and Wikipedia won't be a problem to implement.

For Yandex, http://hg.mozilla.org/releases/l10n/mozilla-aurora/ru/raw-file/b24d40ddc7af/mobile/searchplugins/yandex-ru.xml could be helpful as a base. I can find a contact from Yandex Turkey, if needed.

Milos, could you help creating the patches? Do you need anything from me at this time?
(Assignee)

Comment 2

5 years ago
Selim, thanks for the info. I'll work on the patch today. Do we want the ordering as in the first line in your comment?

Comment 3

5 years ago
Thanks, Milos.

Let's change the order as follows:
Google
Yandex
Wikipedia
Twitter
(Reporter)

Comment 4

5 years ago
(In reply to Milos Dinic [:Milos] from comment #2)
> Selim, thanks for the info. I'll work on the patch today. Do we want the
> ordering as in the first line in your comment?

Milos, what's the status on this patch? Beta 4 will build on Tuesday. Will this patch land by then?
(Reporter)

Comment 5

5 years ago
(In reply to Milos Dinic [:Milos] from comment #2)
> Selim, thanks for the info. I'll work on the patch today. Do we want the
> ordering as in the first line in your comment?

As we're past the beta milestone now, we need to land this in Aurora only. Tr will have to go out with 22.

Thanks Milos
(Assignee)

Comment 6

5 years ago
Created attachment 747501 [details] [diff] [review]
Adding yandex-tr.xml and fixing list.txt and region.properties
Assignee: erkan → milos
Status: NEW → ASSIGNED
Attachment #747501 - Flags: review?(l10n)

Updated

5 years ago
Attachment #747501 - Flags: review?(l10n) → review+
Hi - there needs to be another step and approval in here. Namely, me (as product lead for Fx for Android). The reason is that we are looking at the overall search UX implementation and this touches on a variety of different (and complex) aspects that this needs to be a coordinated approach.

Changing the default (and even adding providers) is one that impacts many different facets of the product and has wider implications than one may realize. 

Saying that, I am not intending to be stop-energy. I am intending to ensure we have solid communication relating to what providers appear in each locale, as well as what the default should be. But I need to be informed to ensure that all checks have been done and that it is supported by the strategic direction.

First off - can I get some clarity in this bug? Is the scope adding Yandex to the Turkish locale? And to be absolutely clear: we are not discussing changing the default, nor any other locales?

Thanks!
Karen

Comment 8

5 years ago
Karen, you are right: We are not discussing changing the default (Google) and this bug will not affect any other locales.

Actually, Yandex is already available on Turkish Firefox for desktop as well. See bug 717933 for more info.
Thanks - and a few more questions for clarity on my side. 

Folks on this bug represent the Turkish community? And the community is wanting this addition because Yandex provides better search results than the search providers already included? Or are we receiving this request elsewhere?

Also note that we won't be rolling in Turkish into the multi-locale build until Fx 23, and I still need to do some cross-checks before feeling comfortable putting this change forward (which I will try to complete as soon as possible!).

Thanks!

Comment 10

5 years ago
No problem. I'll try to clarify things as much as I can.

I represent the Turkish community. All other commenters are from the Mozilla l10n team.

Since we're leaving out Amazon (not available in Turkey/Turkish), we decided to go with "1 extra search engine" option as explained in https://wiki.mozilla.org/L10n:Mobile/Productization. 

We chose Yandex.Turkey over Bing and Yahoo because as opposed to the English-speaking world, neither Bing nor Yahoo provides localized and high-quality search results.
(Assignee)

Comment 11

5 years ago
Karen,

do you need more info, or should I go ahead and push this upstream?
Flags: needinfo?(krudnitski)
Hi Milos,

If you could hold back until I confirm, I would appreciate it. I am just circling one outstanding question to ensure this won't impact one of our side projects. I will try to confirm ASAP!

Karen
Flags: needinfo?(krudnitski)
Hi Milos,

Please go ahead and push this change upstream (adding Yandex to the list but not changing the default search provider from Google).

I do think that the Turkish locale will be included into the fennec multi-lang build in Fx 23, however let's double-check that (but just wanted to set expectations!)

Thanks for your patience!
Karen
(Reporter)

Comment 14

5 years ago
(In reply to Milos Dinic [:Milos] from comment #11)
> Karen,
> 
> do you need more info, or should I go ahead and push this upstream?

Hey Milos,

Looks like this can be pushed. Has this been done? Can we close the bug out?
(Assignee)

Comment 15

5 years ago
Committed in http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/dfb0cab11eb0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 16

5 years ago
fennec-23.0a2.tr.android-arm.apk is the only file not updated yesterday in
https://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-mozilla-aurora-android-l10n/ .

Could it be related to this?

Comment 17

5 years ago
Yes, list.txt needs to say yandex-tr instead of yandex.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is burning the aurora nightlies, please can the fix be landed asap

Updated

5 years ago
Depends on: 882083

Updated

5 years ago
Blocks: 882083
No longer depends on: 882083

Comment 19

5 years ago
Bustage fix landed, http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/9a7c5d9d0d6f.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Thank you :-)
I noticed there's a blank space after "wikipedia-tr". Will the build system ignore that trimming the string?

Comment 22

5 years ago
Well, I don't see Wikipedia in the search engine list. That's probably why.
Log didn't fail this time, and I see a wikipedia-tr.xml in there, so I guess it trims the white space.
https://tbpl.mozilla.org/php/getParsedLog.php?id=24098396&tree=Mozilla-Aurora

Can you check again later?

Comment 24

5 years ago
Awesome. So the build likely ignores the trailing space, but I get the toolkit code that reades list.txt to load the searchplugins from jar:, http://mxr.mozilla.org/mozilla-central/source/toolkit/components/search/nsSearchService.js#3023, doesn't.

so yes, one more bustage fix needed, landed http://hg.mozilla.org/releases/l10n/mozilla-aurora/tr/rev/8e7f0042a7b2. Getting there, iteratively.

Comment 25

5 years ago
(In reply to Francesco Lodolo [:flod] from comment #23)
> Log didn't fail this time, and I see a wikipedia-tr.xml in there, so I guess
> it trims the white space.
> https://tbpl.mozilla.org/php/getParsedLog.php?id=24098396&tree=Mozilla-Aurora
> 
> Can you check again later?

Still no Wikipedia. I'll check again tomorrow to see the result of Axel's patch.

Comment 26

5 years ago
Works properly on today's update.
You need to log in before you can comment on or make changes to this bug.