859389 - fix or disable unreliable calendar tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

The failing tests that I know of are :

1) [calendar] Provider.CaldavPullEvents "before each" hook:
Error: timeout of 2000ms exceeded
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3680)

2) [calendar] Views.ModifyEvent calendar id handling remove calendar (#_removeCalendarId):
Error: removed correct item: expected null to be truthy
at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
at get (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:352)
at ok (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1225)
at (anonymous) (http://calendar.gaiamobile.org:8080/test/unit/views/modify_event_test.js:775)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:40)
at onremovecalendar (http://calendar.gaiamobile.org:8080/test/unit/views/modify_event_test.js:769)
at _removeCalendarId (http://calendar.gaiamobile.org:8080/js/views/modify_event.js:215)
at (anonymous) (http://calendar.gaiamobile.org:8080/js/responder.js:150)
at emit (http://calendar.gaiamobile.org:8080/js/responder.js:146)
at (anonymous) (http://calendar.gaiamobile.org:8080/test/unit/views/modify_event_test.js:779)

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

also:

[calendar] db #transaction "before each" hook:
Error: timeout of 2000ms exceeded
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3680)

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Hey James, any chance you could have a look at this ?

Comment 3

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Note that Bug 868653 will probably disable the tests soon.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> Note that Bug 868653 will probably disable the tests soon.

Is anything still failing here? I ask because in bug#868653, it looks like kevin disabled the assertion as a quick fix... That was 3+ weeks ago, back on 24may. 

If we're all done here, lets close this. If there's anything still to do, please clarify, so we can find, fix and close this bug, so we can unblock bug#833666.

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Nothing landed yet afaik.

Comment 6

[James Lal [:lightsofapollo]]

We have fixed/disabled those tests at this point.