859458 - Add gecko "fingerprint" check to B2G builds to help avoid commercial RIL interface mismatches

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[Michael Vines [:m1] [:evilmachines]]

We are hosting a file called 'gecko_fingerprint.sh' [1] that computes a sha1 based on the contents of important gecko IDL files.  General idea is that a given gecko tree is highly likely to be compatible with the commercial RIL if the sha1 matches.   

"Highly likely" because some of the RIL interfaces are still a little loosely defined, so we may not catch all incompatibilities at the moment.  But we can refine the computation performed by gecko_fingerprint.sh over time, the purpose of this bug is to just get this check added to Moz QA builds as it will definitely help with the bustage we've seen over the last couple weeks.

For convenience the "gecko-fingerprint" sha1 is added to the <x-mozbuild> element in the AU manifest [2].  If there's a sha1 mismatch between the tip Gecko and the tip AU for a given branch then the QA build should fail. 


[1] https://www.codeaurora.org/gitweb/quic/b2g/?p=b2g/build.git;a=blob;f=gecko_fingerprint.sh;h=78448612b0f37272ac6af956161b82c62c325d7d;hb=refs/heads/v1.1
[2] https://www.codeaurora.org/gitweb/quic/b2g/?p=manifest.git;a=blob;f=caf_AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.19.058.xml;h=45f1ffbb8bc4b332bb65fd5bd3d9359d0e9bab0d;hb=051714eb47118af6d72398679ec4df3accd2873b#l3

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Attachment: Reference script to test if the gecko tree matches the fingerprint of a given AU

Comment 2

[Michael Vines [:m1] [:evilmachines]]

Attachment: Reference script to test if the current v1.1 and v1.0.1 tips are compatible

Comment 3

[Chris AtLee [:catlee]]

Thanks Michael.

I think that part of implementing this on Mozilla's side should involve some notification that we've detected a new build or RIL, but not done a repack because of API incompatibilities. This will hopefully prevent "where's today's repack?" type questions.

Comment 4

[Andreas Gal :gal]

Bob, can you assign someone to this? Thanks.

Comment 5

[Tony Chung [:tchung]]

having this fixed would help us catch gecko interface breakage before we generate nightly builds. 

This is related to blocking bug 863395 and bug 828307

Comment 6

[Chris AtLee [:catlee]]

What's the desired behaviour if we fail the API check? Have no nightly builds?

Comment 7

[Michael Vines [:m1] [:evilmachines]]

Yep, jettison the warp core!  A failure likely indicates a binary incompatibility that'll result in a main process crash at boot or during normal telephony operations.

Comment 8

[Chris AtLee [:catlee]]

quick question - why publish a new manifest to git://codeaurora.org/quic/b2g/manifest.git if the fingerprints don't match?

Comment 9

[Michael Vines [:m1] [:evilmachines]]

An AU manifest is of course always compatible with itself.  But what Moz QA wants to do is combine the commercial RIL from the latest AU with the tip Gecko, rather than using the exact Gecko SHA1 from the AU that the commercial RIL was built against (which may be a day or two old by the time the AU is released).   It's within this window that we can suffer an ABI incompatibility.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To note : We can't test the latest features that lands if we don't test close to the tip.

Also a number of fixes come in the latest lands that we have to test against.  Some of the fixes unblocks us from testing certain features.  Example is Leo's last build doesn't show music in the music app, and there's a fix already in gaia for that.

Comment 11

[Chris AtLee [:catlee]]

Not getting updated RILs any more for automation