859491 - -Wreorder build warning for XPCJSRuntime constructor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning (seen on my local m-i build):
{
js/xpconnect/src/xpcprivate.h: In constructor ‘XPCJSRuntime::XPCJSRuntime(nsXPConnect*)’:

js/xpconnect/src/xpcprivate.h:968:10: warning: ‘XPCJSRuntime::mExceptionManagerNotAvailable’ will be initialized after [-Wreorder]

js/xpconnect/src/xpcprivate.h:964:15: warning:   ‘JSObject* XPCJSRuntime::mJunkScope’ [-Wreorder]

js/xpconnect/src/XPCJSRuntime.cpp:2637:1: warning:   when initialized here [-Wreorder]
}

hg blame says this was introduced by https://hg.mozilla.org/mozilla-central/rev/36fcd3edc6b8 (bug 820170)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

The fix sticks mJunkScope after mLastActiveTime and before mExceptionManagerNotAvailable.

Here's a snippet of the header file, as touched by the commit in comment 0, to show that the new ordering is correct:
    3.28      PRTime mLastActiveTime; // -1 if active NOW
    [...]
    3.31 +    JSObject* mJunkScope;
    [...]
    3.35      bool mExceptionManagerNotAvailable;
    https://hg.mozilla.org/mozilla-central/rev/36fcd3edc6b8#l3.28

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/167fecb7c112

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/167fecb7c112