Document lang/functional module

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jsantell, Assigned: jsantell)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Assignee: nobody → jsantell
Created attachment 735937 [details]
GH Pull Request 933
Attachment #735937 - Flags: review?(wbamberg)
Comment on attachment 735937 [details]
GH Pull Request 933

Thanks for this. A bunch of language nits, and one misleading thing.
Attachment #735937 - Flags: review?(wbamberg) → review-
Created attachment 736365 [details]
GH Pull Request 933

Fixed the nits and added some examples!
Attachment #736365 - Flags: review?(wbamberg)

Updated

6 years ago
Priority: -- → P3
Comment on attachment 736365 [details]
GH Pull Request 933

Looks great, but there's one typo in the documentation for "defer()" that needs fixing: "you to you these functions" -> "you to use these functions".
Attachment #736365 - Flags: review?(wbamberg) → review+

Comment 5

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ef3205b22445242ce036bf2b3a5d0abe08a0804b
Merge pull request #933 from jsantell/func-documentation

fix bug 859507: Document lang/functional module, r=@wbamberg

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
Commit pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ef3205b22445242ce036bf2b3a5d0abe08a0804b
Merge pull request #933 from jsantell/func-documentation
You need to log in before you can comment on or make changes to this bug.