Closed Bug 859521 Opened 7 years ago Closed 6 years ago

Add AWS EC2 to PSL

Categories

(Core :: Networking: Domain Lists, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: weppos, Assigned: weppos)

Details

Attachments

(1 file, 1 obsolete file)

Posted on behalf of Osman Surkatty.

I'd like to provide an update to lists under *.amazonaws.com for EC2 related resources. Please see the diff below:

$ diff the_list.txt the_list2.txt
6963a6964,6979
> // Amazon Elastic Compute Cloud (EC2): https://aws.amazon.com/ec2/
> // ...
> compute.amazonaws.com
> us-east-1.amazonaws.com
> compute-1.amazonaws.com
> z-1.compute-1.amazonaws.com
> z-2.compute-1.amazonaws.com
> ap-northeast-1.compute.amazonaws.com
> ap-southeast-1.compute.amazonaws.com
> ap-southeast-2.compute.amazonaws.com
> eu-west-1.compute.amazonaws.com
> sa-east-1.compute.amazonaws.com
> us-gov-west-1.compute.amazonaws.com
> us-west-1.compute.amazonaws.com
> us-west-2.compute.amazonaws.com
Validated via email.
Attachment #734845 - Flags: review?(gerv)
Comment on attachment 734845 [details] [diff] [review]
Patch for AWS EC2

Would this not be better as:

compute.amazonaws.com
us-east-1.amazonaws.com
compute-1.amazonaws.com
*.compute.amazonaws.com
*.compute-1.amazonaws.com

? We should check with Amazon about that, as the above would be more future-proof.

Gerv
Attachment #734845 - Flags: review?(gerv) → review+
Comment on attachment 734845 [details] [diff] [review]
Patch for AWS EC2

Oops. Fixing review flag.

Gerv
Attachment #734845 - Flags: review+ → review-
Attached patch Patch for Amazon EC2 (obsolete) — Splinter Review
Osman agreed with the changes.
Attachment #734845 - Attachment is obsolete: true
Attachment #743107 - Flags: review?(gerv)
Comment on attachment 743107 [details] [diff] [review]
Patch for Amazon EC2

r=gerv.

Gerv
Attachment #743107 - Flags: review?(gerv) → review+
 http://hg.mozilla.org/integration/mozilla-inbound/rev/481e9a3d1cf2 - Ryan VanderMeulen - Backed out changeset f8a861253c57 (bug 859521) due to bustage.

The parsing script suggests that saying:

compute.amazonaws.com
...
*.compute.amazonaws.com

is bogus. It takes a bit of thinking about, but it's right. My rewrite was not the same as the submitted list. Take foo.compute.amazonaws.com. With the submitted list, the public suffix is compute.amazonaws.com (matching rule: "compute.amazonaws.com"). With my modification, the public suffix is foo.compute.amazonaws.com (matching rule: "*.compute.amazonaws.com").

I suck :-| We should go back to what Osman submitted.

Gerv
Attachment #734845 - Attachment is obsolete: false
Attachment #743107 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7b39c8bec295
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.