859548 - [Profile] Require country field

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[William Reynolds [:williamr]]

User stories:
As a user, I need to provide my country when updating my profile.

Design:
Add a red asterisk (*) after the 'Country' label so the user knows the field is required.

Consideration:
This feature applies to all existing accounts, including users who do not currently have a country on their profile. In order for those users to update their profile, they will now have to provide their country.

Error message:
This field is required.

Acceptance criteria:
- When editing your profile, selecting a country for your profile is required.
- A visual indicator is shown next to the 'Country' label to show that it is a required field.
- If you do not select a country when updating your profile, an error message is displayed.

Comment 1

[John Kim [snoozes]]

Hello.  Would it be alright if I could be assigned to work on this bug for my software engineering assignment?

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Hi John, thanks for your interest in contributing! This is a great bug to jump in on. 

We're hoping this bug will be launched in the next couple of weeks, so if you have time to work on it soon, I'm happy to assign it to you. If you submit a good pull request the fix will be live on the site soon after.

You can review the release process here:

https://wiki.mozilla.org/Mozillians/Releases/Process

And the development workflow is here:

http://mozillians.readthedocs.org/en/latest/contribute.html#git-workflow

Do you think you'll have time to work on this in the next week or two? If so, please assign it to yourself and have fun!

Please jump into #commtools on irc.mozilla.org if you need any help or want to chat about Mozillians.org development.

Comment 4

[Giorgos Logiotatidis [:giorgos]]

From bug 859547 - Country field should be required to complete registration

Comment 5

[John Kim [snoozes]]

I'm sorry but I do not think that I will be able to fix this within the given time frame for my partner and I are already assigned a bug to fix within the same time frame.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

OK John. I just sent you an email with some other bugs for you to consider.

Maybe :sancus or :giorgos can pick this one up in the near future?

Comment 7

[John Kim [snoozes]]

Thank you very much for the list of bugs!  My partner and I will take a look at those.

Comment 8

[Michał Frontczak [:fxa90id] ♥]

Hi, Im working on it now, and I dont know what to do :(. I was thinking about adding new arg for boostrap function in helper.py like required, if yes then use template field_required.html, what do you think about that ?

Comment 9

[Giorgos Logiotatidis [:giorgos]]

I believe you only need to 

1. Remove blank=True from country in users/models.py

and you're done. 

Using the 'required' html5 attribute is a great idea, and can be accomplished with the 'field_with_attrs' helper but currently none of the other mandatory registration fields use it, so I'd better avoid it for the time being.

Comment 10

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/mozillians/pull/476

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/efade94bdb3660f14e23db862911727e3c517598
[fix bug 859548] [Profile] Require country field

https://github.com/mozilla/mozillians/commit/502ceafe77a9ba896ac7bcaadaeefb2dc05a9565
Merge pull request #476 from fxa90id/Bug_859543_v2

[fix bug 859548] [Profile] Require country field

Comment 12

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening:

When a user edits their profile (/user/edit/) there should be a red asterisk (*) after the 'Country' label indicating the field is required (comment 0).

Currently there is no indicator to the user that the field is required until they submit their changes. If the 'Country' is left blank only then is an error message displayed.

Comment 13

[Matt Brandt [:mbrandt]]

Attachment: qa - example of current error message

Here is an example of the error message that occurs when a user attempts to submit an empty Country field.

Comment 14

[Michał Frontczak [:fxa90id] ♥]

Sorry forgot about asteriks, should I make like I said https://bugzilla.mozilla.org/show_bug.cgi?id=859548#c8 ?

Comment 15

[Giorgos Logiotatidis [:giorgos]]

(In reply to Matt Brandt [:mbrandt] from comment #12)
> Created attachment 753414 [details]
> qa - reopened
> 
> Reopening:
> 
> When a user edits their profile (/user/edit/) there should be a red asterisk
> (*) after the 'Country' label indicating the field is required (comment 0).
> 
> Currently there is no indicator to the user that the field is required until
> they submit their changes. If the 'Country' is left blank only then is an
> error message displayed.

Valid point Matt but we don't have an asterisk for 'full name' or the agreement checkbox which are also required. I don't know if we should tackle these in this bug or go for the UI/UX branch / initiative.

Thoughts?

Comment 16

[Matt Brandt [:mbrandt]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #15)
> I don't know if we should tackle
> these in this bug or go for the UI/UX branch / initiative.
> 
> Thoughts?
To be honest I think it's good enough for now as is and we can mark can bump this back to FIXED. The UX overhaul is on the horizon.

Comment 17

[Matt Brandt [:mbrandt]]

Bumping to resolved fixed per comment 16

Comment 18

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage - country field is required. When a user does not supply a Country of residence an appropriate error message is displayed and the user is prevented from saving the change to their profile.