859555 - [Settings] non-translatable information in the network operator list

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Leo]

1. Title : [Token] Untranslated token appears when searching for mobile networks
2. Precondition : 
3. Tester's Action : Perform manual mobile NW search
4. Detailed Symptom (ENG.) : The status of the results are in English when the selected language is Spanish.
5. Expected : 
The following tokens should be changed:
   - "current" -> "conectado"
   - "available" -> "disponible"
   - "forbidden" -> "prohibida"

Comment 1

[Leo]

Attachment: screenshot

Comment 2

[Wayne Chang [:wchang]]

Triage 4/10 - setting tracking+ as most users wont be manual searching often, but translation is required.

Comment 3

[Michał Budzyński (:michalbe)]

Attachment: patch

Etienne: since Kaze is on PTO, and 'git blame' showed me that you made some changes in the files I modified, could you please r? this tiny patch?

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 741002 [details]
patch

r=me with the comment addressed for the code, flagging for l10n review too.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 741002 [details]
patch

(:l10n is an alias, not the most reliable method to get a review)

v1-train doesn't need l10n review, you should get copy review if needed from UX.

In this case, I guess it's needed, as we're using lower-case strings here, and I'm not sure that's right. Trying Josh for review. We might actually need real copy here, too.

Comment 7

[hyuna.cho]

leo should be translated in es, PT-BR.
Could you add es, PT-BR string also.

Comment 8

[Axel Hecht [:Pike]]

Translations are made outside of the gaia git repository. The french version that's update here won't matter for production and test builds, it's just there for developers.

Comment 9

[hyuna.cho]

(In reply to Axel Hecht [:Pike] from comment #8)
> Translations are made outside of the gaia git repository. The french version
> that's update here won't matter for production and test builds, it's just
> there for developers.

How can I request about translation? 
Let me know about translation process.
When the translation is complete about other languages, I would like to know.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 741002 [details]
patch

Actually noting my negative feedback on the strings in this patch, for clarity.

hyuna.cho, localization is too complex a topic to put it into a bug comment. In short, once strings land on v1-train, they get picked up, and exposed to our l10n community. The builds we and partners produce pick up the latest localizations then. There's tons of technical detail here that's not helpful for this bug.

Comment 11

[Francesco Lodolo [:flod]]

+state-connected = current
+state-current = current 

Ignoring the lower-case for a moment, sure the first "current" shouldn't be "connected"?

Comment 12

[Josh Carpenter [:jcarpenter]]

(In reply to Francesco Lodolo [:flod] from comment #11)
> +state-connected = current
> +state-current = current 
> 
> Ignoring the lower-case for a moment, sure the first "current" shouldn't be
> "connected"?

Agreed. Should be:

"Connected"
"Available"
"Forbidden"

Comment 13

[Michał Budzyński (:michalbe)]

I used lowercase strings because that is how it works now. Changed to uppercase and patch updated

Comment 14

[Francesco Lodolo [:flod]]

Still wrong, now you have a "state-current" string with "Connected" inside

+state-connected = Connected
+state-current = Connected

Comment 15

[Michał Budzyński (:michalbe)]

Merged: https://github.com/mozilla-b2g/gaia/commit/8bcd3d970a76093385f65a0acfcaa023654572bc

Comment 16

[Michał Budzyński (:michalbe)]

:flod its on purpose, Connected & Current is the same thing.

Comment 17

[Francesco Lodolo [:flod]]

Comment 12 seemed to agree with me. Anyway, if that's the case why do you need to distinct strings?

Comment 18

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 8bcd3d970a76093385f65a0acfcaa023654572bc
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 19

[Gareth Aye [:gaye] (back from PTO)]

Any update on the merge conflict?

Comment 20

[Michał Budzyński (:michalbe)]

Pull request with merge conflict resolved waiting for landing: https://github.com/mozilla-b2g/gaia/pull/9992

Comment 21

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 53055a5

Comment 22

[Tony Chung [:tchung]]

Testcase needed just to make sure the string is localized, not to test the actual string translation.