85960 - --enable-crypto no longer builds

Status: RESOLVED FIXED

(NSS :: Build, defect, P1)

Description

[lidl]

Yesterday evening, I did a CVS update of the tip of the Mozilla tree
and did the equivilent of a 'clobber' build of the sources.

With the updates in the NSS component that got sucked over, my
tree no longer successfully builds.

I think you could replicate this failure on the tinderbox machine
'muerte' by uncommenting the --enable-crypto flag in the .mozconfig
file (or equivilent).

For reference, this is on a BSD/OS 4.2 machine (x86).

I'm going to attach a full build log so you can see exactly how and
where it fails.

Comment 1

[Wan-Teh Chang]

Please let me know the build procedure you used.  Thanks. 

Comment 2

[lidl]

For some reason, bugzilla will not accept my (2.6MB) attachement.

Here's the .mozconfig file that I have been using...

mk_add_options MOZ_OBJDIR=/mnt/proj/obj/mozilla
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --enable-optimize="-O2 -mcpu=pentiumpro -march=pentium"
ac_add_options --with-libIDL-prefix=/usr/contrib/gnome
ac_add_options --with-libIDL-exec_prefix=/usr/contrib/gnome/bin
ac_add_options --with-gdk-pixbuf-prefix=/usr/contrib/gnome
ac_add_options --with-gdk-pixbuf-exec_prefix=/usr/contrib/gnome/bin

ac_add_options --disable-mailnews
ac_add_options --enable-strip-libs
ac_add_options --enable-crypto
ac_add_options --disable-pedantic
ac_add_options --with-gtk
ac_add_options --with-pthreads
ac_add_options --with-jpeg
ac_add_options --with-png
ac_add_options --with-zlib
ac_add_options --enable-nspr-autoconf

Here's the script that I actually run that builds the beast:

#! /bin/sh
PROJ=mozilla
SRCDIR=/scratch/proj/src/${PROJ}
OBJDIR=/mnt/proj/obj/${PROJ}
LOG=mmake.log

cd $OBJDIR || exit 1
\rm -rf * || exit 2
# attempt to flush out a bunch of the dirty blocks from
# the soft-dep code
sync; sync; sync; sync

date > ${LOG}
sync
${SRCDIR}/configure  >> ${LOG} 2>&1
gmake export >> ${LOG} 2>&1 && gmake install >> ${LOG} 2>&1
date >> ${LOG}
sync

exit 0

Comment 3

[lidl]

Attachment: Gzipped log file of the failing build

Comment 4

[Wan-Teh Chang]

Thanks for the builg log.  I extracted the relevant part below.
I can reproduce it on muerte.  I'm looking at it now.

--------------------------------------------------------------------------

gmake[1]: Entering directory `/mnt/proj/obj/mozilla/security/manager'
gmake -C /scratch/proj/src/mozilla/security/coreconf MAKE="gmake -j1" -j1 MOZILL
A_INCLUDES="-I/mnt/proj/obj/mozilla/dist/include/nspr -I/mnt/proj/obj/mozilla/di
st/include/dbm" SOURCE_MD_DIR=/mnt/proj/obj/mozilla/dist DIST=/mnt/proj/obj/mozi
lla/dist MOZILLA_CLIENT=1 NO_MDUPDATE=1 BUILD_TREE=/mnt/proj/obj/mozilla BUILD_O
PT=1 NS_USE_GCC=1 NS_USE_NATIVE=
gmake[2]: Entering directory `/scratch/proj/src/mozilla/security/coreconf'
cd nsinstall; gmake -j1 export
gmake[3]: Entering directory `/scratch/proj/src/mozilla/security/coreconf/nsinst
all'
gmake[3]: Nothing to be done for `export'.
gmake[3]: Leaving directory `/scratch/proj/src/mozilla/security/coreconf/nsinsta
ll'
Thu Jun 14 13:29:31 EDT 2001
Skipping non-directory mkdepend...
Thu Jun 14 13:29:31 EDT 2001
Skipping non-directory md...
Thu Jun 14 13:29:31 EDT 2001
cd nsinstall; gmake -j1 libs
gmake[3]: Entering directory `/scratch/proj/src/mozilla/security/coreconf/nsinst
all'
mkdir: /mnt/proj/obj/mozilla/nss/: No such file or directory
gmake[3]: *** [/mnt/proj/obj/mozilla/nss//nsinstall.o] Error 1

Comment 5

[Wan-Teh Chang]

OK.  The problem is that the 'mkdir' command on BSD/OS 4.2
does not like a directory pathname with a trailing /.

So this is okay:
    % mkdir foo
But this is not okay:
    % mkdir bar/

I will attach a patch for you to test.

Comment 6

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 7

[lidl]

With the proposed patch, the nss system builds once again.

As far as I am concerned this bug can be closed out.
(I'm submitting this update on the problem from the browser
that I just built.)

Thanks for your speedy attention to this problem!

Comment 8

[Javier Delgadillo]

r=javi

Comment 9

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for the trunk

Comment 10

[Wan-Teh Chang]

I checked in the patch on the NSS_3_2_BRANCH and moved the
NSS_CLIENT_TAG to include it.

I also checked in the patch on the trunk of NSS.

Comment 11

[Wan-Teh Chang]

The fix is not in 3.2.2 but is in 3.3 and the 3.2 branch.
Since we are not planning to make any new 3.2.x releases,
I am setting the target milestone to 3.3.