Closed Bug 859631 Opened 8 years ago Closed 7 years ago

Intermittent webapps/test_uninstall_errors.xul, test_uninstall_errors.html | Test timed out.

Categories

(Core Graveyard :: DOM: Apps, defect)

x86
Windows 8
defect
Not set
normal

Tracking

(firefox25 fixed, firefox26 fixed, firefox27 fixed, firefox-esr24 fixed)

RESOLVED FIXED
mozilla27
Tracking Status
firefox25 --- fixed
firefox26 --- fixed
firefox27 --- fixed
firefox-esr24 --- fixed

People

(Reporter: RyanVM, Assigned: marco)

Details

(Keywords: intermittent-failure, Whiteboard: [apps-automation:P3])

Attachments

(1 file, 3 obsolete files)

https://tbpl.mozilla.org/php/getParsedLog.php?id=21568577&tree=Mozilla-Inbound

WINNT 6.2 mozilla-inbound opt test mochitest-other on 2013-04-08 10:30:49 PDT for push e5cf40b38bd7
slave: t-w864-ix-002

17:36:21     INFO -  10234 INFO TEST-START | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_uninstall_errors.xul
17:41:48     INFO -  10235 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_uninstall_errors.xul | Test timed out.
17:41:48     INFO -  args: ['C:\\slave\\test\\build\\tests\\bin\\screenshot.exe', 'c:\\users\\cltbld~1.t-w\\appdata\\local\\temp\\mozilla-test-fail_ttnptl']
17:41:48     INFO -  SCREENSHOT: <see log>
17:41:49     INFO -  10236 INFO TEST-END | chrome://mochitests/content/chrome/dom/tests/mochitest/webapps/test_uninstall_errors.xul | finished in 327695ms
Whiteboard: [apps-automation]
Whiteboard: [apps-automation] → [apps-automation:P3]
(OrangeWFM bugs not touched for 2 months)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
I think the problem here is that the install onsuccess function could be called while the installation is still in progress. So confirmNextInstall could fail to accept the installation.

We could either wait for bug 906114 and see if it fixes the problem, or land this patch and see if it fixes the problem.
Attachment #806787 - Flags: review?(fabrice)
Attached patch Log installations (obsolete) — Splinter Review
Or we could just log the installations for now, so that we could better understand the problem.
Attachment #806791 - Flags: review?(fabrice)
Attached patch Patch (obsolete) — Splinter Review
Another solution similar to the first patch, but that also moves the test in dom/apps so that it's executed on b2g and Android too.
Attachment #806949 - Flags: feedback?(fabrice)
Comment on attachment 806949 [details] [diff] [review]
Patch

Review of attachment 806949 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but can you do a try run?
Attachment #806949 - Flags: feedback?(fabrice) → feedback+
Attachment #806791 - Flags: review?(fabrice)
Attachment #806787 - Flags: review?(fabrice)
Attached patch PatchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=493b45f2398b
Attachment #806787 - Attachment is obsolete: true
Attachment #806791 - Attachment is obsolete: true
Attachment #806949 - Attachment is obsolete: true
Attachment #807241 - Flags: review?(fabrice)
Attachment #807241 - Attachment description: prova → Patch
Attachment #807241 - Attachment filename: prova → Patch
Attachment #807241 - Flags: review?(fabrice) → review+
Let's see if this fixes the problem before closing the bug.
Keywords: checkin-needed
Whiteboard: [apps-automation:P3] → [apps-automation:P3][leave open]
Assignee: nobody → mcastelluccio
Status: REOPENED → ASSIGNED
Whiteboard: [apps-automation:P3][leave open] → [apps-automation:P3]
Notice that now the test is dom/apps/test_uninstall_errors.html. If it fails, we shouldn't open a new bug.
(In reply to Marco Castelluccio [:marco] from comment #30)
> Notice that now the test is dom/apps/test_uninstall_errors.html. If it
> fails, we shouldn't open a new bug.

Yes, but the xul one is still on other branches so this one may happen again.
Summary: Intermittent webapps/test_uninstall_errors.xul | Test timed out. → Intermittent webapps/test_uninstall_errors.xul, test_uninstall_errors.html | Test timed out.
(For TBPL bug suggestion matching)
(In reply to Marco Castelluccio [:marco] from comment #24)
> Let's see if this fixes the problem before closing the bug.

(In reply to Fabrice Desré [:fabrice] from comment #31)
> Yes, but the xul one is still on other branches so this one may happen again.

Once this is resolved, I can assure you that the other branches will be picking up this fix in short order :)
I think we can mark this as resolved now.
Target Milestone: --- → mozilla27
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.