859692 - Show some progress indicator UI when backing up bookmarks

Status: RESOLVED INCOMPLETE

(Toolkit :: Places, defect)

Description

[Raymond Lee [:raymondlee]]

From bug 862041 comment 11

> diff -r de4f34069146 browser/components/places/content/places.js
> --- a/browser/components/places/content/places.js	Sun Apr 07 22:59:33 2013 -0700
> +++ b/browser/components/places/content/places.js	Mon Apr 08 13:16:34 2013 +0300
> @@ -465,17 +465,17 @@
>     */
>    backupBookmarks: function PO_backupBookmarks() {
>      let dirSvc = Cc["@mozilla.org/file/directory_service;1"].
>                   getService(Ci.nsIProperties);
>      let backupsDir = dirSvc.get("Desk", Ci.nsILocalFile);
>      let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);
>      let fpCallback = function fpCallback_done(aResult) {
>        if (aResult != Ci.nsIFilePicker.returnCancel) {
> -        PlacesUtils.backups.saveBookmarksToJSONFile(fp.file);
> +        BookmarkJSONUtils.exportToFile(fp.file);

Given the backup-and-exit is an expected use case, please file a follow up for some progress indicator UI. As it is, one could hit backup, close the browser and expect the backup to be in place.

Comment 1

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #0)
> From bug 862041 comment 11
> 
 Should be bug 852041

Comment 2

[Marco Bonardo [:mak]]

Very low priority, we should rather try to backup in background, silently.

I think this will end up being a wontfix in favor of NOT backing out on shutdown.

Comment 3

[Marco Bonardo [:mak]]

we don't backout on shutdown anymore, in general.
There's another bug about showing some ui when we exit during a backup though.