Closed
Bug 859774
Opened 11 years ago
Closed 11 years ago
Values of readyState in nsDOMDataChannel don't match the spec
Categories
(Core :: WebRTC: Networking, defect)
Core
WebRTC: Networking
Tracking
()
VERIFIED
FIXED
mozilla23
People
(Reporter: whimboo, Assigned: jesup)
Details
(Whiteboard: [webrtc][blocking-webrtc-][spec-issue])
Attachments
(1 file)
1.10 KB,
patch
|
smaug
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As landed on bug 733002 the values of the nsDOMDataChannel readyState don't match the spec. http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCDataChannelState enum RTCDataChannelState { "connecting", "open", "closing", "closed" }; http://hg.mozilla.org/mozilla-central/diff/ed6491f2335e/content/base/src/nsDOMDataChannel.cpp#l1.201 1.201 + const char * stateName[] = { 1.202 + "Connecting", 1.203 + "Open", 1.204 + "Closing", 1.205 + "Closed" 1.206 + };
Comment 1•11 years ago
|
||
Valid bug, but not blocking.
Whiteboard: [WebRTC] → [WebRTC][blocking-webrtc-][spec-issue]
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 735224 [details] [diff] [review] change DataChannel readyState names to match spec (capitalization) Trivial patch to fix capitalization of readyState values to match spec
Attachment #735224 -
Flags: review?(bugs)
Assignee | ||
Comment 4•11 years ago
|
||
Given the low risk, I'd uplift this patch to Aurora 22
Whiteboard: [WebRTC][blocking-webrtc-][spec-issue] → [webrtc][blocking-webrtc-][spec-issue][webrtc-uplift]
Comment 5•11 years ago
|
||
Comment on attachment 735224 [details] [diff] [review] change DataChannel readyState names to match spec (capitalization) http://dev.w3.org/2011/webrtc/editor/webrtc.html#idl-def-RTCDataChannelState
Attachment #735224 -
Flags: review?(bugs) → review+
Reporter | ||
Comment 6•11 years ago
|
||
Randell, don't we have any unit test for data channel yet which would cover certain states of the data channel state, e.g. after calling createDataChannel state has to be 'connecting'?
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•11 years ago
|
||
Some of these may be hard to test, since states can be transitory. However, I think it's testable now.
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd9e94fd401f
status-firefox21:
--- → disabled
status-firefox22:
--- → affected
status-firefox23:
--- → affected
Target Milestone: --- → mozilla23
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #7) > Some of these may be hard to test, since states can be transitory. However, > I think it's testable now. Do you wanna add tests on an unit test level? If that's not doable I could fold this into our datachannel mochitests.
Flags: in-testsuite?
Comment 10•11 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #9) > (In reply to Randell Jesup [:jesup] from comment #7) > > Some of these may be hard to test, since states can be transitory. However, > > I think it's testable now. > > Do you wanna add tests on an unit test level? If that's not doable I could > fold this into our datachannel mochitests. FWIW, we probably should add the tests through mochitests, anyways. That falls in line with one of pieces of automation we need - attribute state checking.
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd9e94fd401f
Assignee: nobody → rjesup
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 735224 [details] [diff] [review] change DataChannel readyState names to match spec (capitalization) [Approval Request Comment] Bug caused by (feature/regressing bug #): n/a User impact if declined: some applications will fail to see the states they expect per the spec, or may write code that uses our incorrect values. Testing completed (on m-c, etc.): on m-c. Risk to taking this patch (and alternatives if risky): nil - simple string changes for states (capitalization) to match the spec. String or IDL/UUID changes made by this patch: no user-facing changes, just strings used as states in JS (no l10n issues).
Attachment #735224 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Comment 13•11 years ago
|
||
Verified through a sanity check that I'm seeing two of the states in caps form.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Updated•11 years ago
|
Attachment #735224 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 14•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/913019e93240
Whiteboard: [webrtc][blocking-webrtc-][spec-issue][webrtc-uplift] → [webrtc][blocking-webrtc-][spec-issue]
You need to log in
before you can comment on or make changes to this bug.
Description
•