Closed Bug 859997 Opened 11 years ago Closed 11 years ago

Work - Overlay plus button

Categories

(Firefox for Metro Graveyard :: App Bar, defect)

All
Windows 8.1
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fryn, Assigned: fryn)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
The second half of bug 836791.
Attached patch patch v2Splinter Review
I'm using observes="cmd_back", since the buttons need to show up and hide together.
Attachment #735364 - Attachment is obsolete: true
Attachment #735416 - Flags: review?(mbrubeck)
Comment on attachment 735416 [details] [diff] [review]
patch v2

Review of attachment 735416 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/theme/browser.css
@@ +975,5 @@
> +#overlay-plus {
> +  right: -72px;
> +  background-image: url(chrome://browser/skin/images/overlay-plus.png);
> +  background-position: left 6px center;
> +}

We'll need to override a bunch of this stuff for right-to-left locales, but we can wait until the UI stabilizes a bit before tackling that.
Attachment #735416 - Flags: review?(mbrubeck) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> We'll need to override a bunch of this stuff for right-to-left locales, but
> we can wait until the UI stabilizes a bit before tackling that.

Right! I won't forget that. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0f04f764a7
https://hg.mozilla.org/mozilla-central/rev/6f0f04f764a7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 835628
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: