860039 - Crash when attempting to 'pop out' a chat conversation in gmail

Status: RESOLVED WORKSFORME

(Firefox for Metro Graveyard :: Browser, defect, P2)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

STR:
  Navigate to gmail.com
  Start a chat conversation
  Select the icon to 'pop out' the conversation into a new window


On desktop Firefox, a new window would be created containing the chat conversation
On immersive/Metro Firefox, the browser crashes

Comment 1

[Matt Brubeck (:mbrubeck)]

Possibly related to bug 815298.

Comment 2

[Jim Mathies [:jimm]]

Are there any crash reports in about:crashes that correspond to this?

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

No crashes appear in about:crashes.

I just tried to repro this and I was actually able to 'pop out' the conversation; it ended up in a new tab which I think is exactly what we want.  However, after I moved to another tab and tried to come back to the conversation, the process got killed.  This might be because I'm running a debug build and the tab causes a lot of log messages to get spewed out, which hangs the process temporarily and might make metro decide to kill it.

If this doesn't happen in release builds then it should be resolved invalid.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Tim Abraldes (:tabraldes) (:TimAbraldes) from comment #3)
> No crashes appear in about:crashes.
> 
> I just tried to repro this and I was actually able to 'pop out' the
> conversation; it ended up in a new tab which I think is exactly what we
> want.  However, after I moved to another tab and tried to come back to the
> conversation, the process got killed.  This might be because I'm running a
> debug build and the tab causes a lot of log messages to get spewed out,
> which hangs the process temporarily and might make metro decide to kill it.

I see this pretty often, even in release builds generally doing stuff in the browser. Most common is on initial startup. We'll never get crash stacks since the process is terminated. I think the culprit is main thread latency in processing native events. I'll file a meta bug on this.

Comment 5

[Brian R. Bondy [:bbondy]]

p=2

Comment 6

[Marco Mucci [:MarcoM]]

Hey Brian, based on the conversations at the Work Week and your point value in Comment #5, can this bug be turned into an actionable Defect to be worked on in a future iteration?

Comment 7

[Brian R. Bondy [:bbondy]]

Dd you have some ideas on this? I thought we were just going to mark this as wontfix.
I think it's related to too much logging and windows killing the process.

Comment 8

[Sam Foster [:sfoster] (he/him)]

In the monday meeting we discussed whether: 
* This was truly a debug-only bug related to logging (therefore wontfix)
* Reproducible (sometimes) in a release build (therefore warrants investigation)
* If this is a performance problem associated with creating all new tabs
* If something about the gmail use case is triggering some other bug or performance issues - perhaps they document.open/write/close to populate the new window?
* Extending existing tab creation tests to exercise a few more of these common use cases

Might be this belongs on another ticket.

Comment 9

[Jim Mathies [:jimm]]

We gave it a p2 so that someone would have to investigate before we roll out.

Comment 10

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

I tested this using the latest available Nightly.  There were no noticeable performance problems.

The behavior mentioned in this bug seems to be related to log messages that occur in debug builds on gmail (and possibly other sites).  I don't think we should change our logging behavior, so there's nothing to do here.