Created attachment 735428 [details] [diff] [review] patch v1: don't log by default; remove extraneous newlines TCPSocket logs debug messages by default and adds an extra newline to some of them. It should do neither.
Attachment #735428 - Flags: review?(jonas)
Jonas: is there someone else who should review this? Perhaps Fabrice can take it?
Attachment #735428 - Flags: review?(jonas) → review+
Created attachment 750763 [details] [diff] [review] patch v2: resolves trivial conflicts This version resolves trivial conflicts with recent changes to the same areas of the file. Carrying forward review. This is the version I'll commit.
Comment on attachment 750763 [details] [diff] [review] patch v2: resolves trivial conflicts https://hg.mozilla.org/integration/mozilla-inbound/rev/efbb1fb5e563
Attachment #750763 - Flags: checkin+
Thanks for fixing that!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.