TCPSocket logs debug messages by default, adds extra newline

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

unspecified
mozilla24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 735428 [details] [diff] [review]
patch v1: don't log by default; remove extraneous newlines

TCPSocket logs debug messages by default and adds an extra newline to some of them.  It should do neither.
Attachment #735428 - Flags: review?(jonas)
(Assignee)

Comment 1

5 years ago
Jonas: is there someone else who should review this?  Perhaps Fabrice can take it?
Flags: needinfo?(jonas)
(Assignee)

Comment 2

5 years ago
Created attachment 750763 [details] [diff] [review]
patch v2: resolves trivial conflicts

This version resolves trivial conflicts with recent changes to the same areas of the file.  Carrying forward review.  This is the version I'll commit.
Attachment #735428 - Attachment is obsolete: true
Attachment #750763 - Flags: review+
Thanks for fixing that!
https://hg.mozilla.org/mozilla-central/rev/efbb1fb5e563
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.