860043 - TCPSocket logs debug messages by default, adds extra newline

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: don't log by default; remove extraneous newlines

TCPSocket logs debug messages by default and adds an extra newline to some of them.  It should do neither.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Jonas: is there someone else who should review this?  Perhaps Fabrice can take it?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: resolves trivial conflicts

This version resolves trivial conflicts with recent changes to the same areas of the file.  Carrying forward review.  This is the version I'll commit.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 750763 [details] [diff] [review]
patch v2: resolves trivial conflicts

https://hg.mozilla.org/integration/mozilla-inbound/rev/efbb1fb5e563

Comment 4

[Donovan Preston [:fzzzy]]

Thanks for fixing that!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/efbb1fb5e563