Remove non-namespaced JSHandle names

RESOLVED FIXED in mozilla23

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Unassigned)

Tracking

Trunk
mozilla23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(9 attachments)

(Reporter)

Description

5 years ago
These are for legacy C compatibility. I expect this is thoroughly rotted by now. If anyone needs them later, they can easily re-add them in the c-api wrapper's header.
(Reporter)

Comment 1

5 years ago
Created attachment 738075 [details] [diff] [review]
JSRawObject; 1of2; v0

This patch was generated by running the following two command:
find js/ -name "*.cpp" -or -name "*.h" | xargs sed -i 's/JSRawObject /JSObject */g'
find . -name "*.cpp" -or -name "*.h" | xargs sed -i 's/JSRawObject/JSObject*/g'

Ack confirms that there are no more references. A follow-up removes the definition and the one place where the above simple script does not work.
Attachment #738075 - Flags: review?(jcoppeard)
(Reporter)

Comment 2

5 years ago
Created attachment 738076 [details] [diff] [review]
JSRawObject; 2of2; v0

I will fold this with the first before pushing.

Try run is green:
https://tbpl.mozilla.org/?tree=Try&rev=58c10c995baa
Attachment #738076 - Flags: review?(jcoppeard)
(Reporter)

Comment 3

5 years ago
Created attachment 738186 [details] [diff] [review]
JSRawString; 1of1; v0

Removed manually since there were only 5 occurrences.
Attachment #738186 - Flags: review?(jcoppeard)
(Reporter)

Comment 4

5 years ago
Created attachment 738187 [details] [diff] [review]
JSRaw*; 1of1; v0

Trivial: the rest of the JSRaw have no uses.
Attachment #738187 - Flags: review?(jcoppeard)
(Reporter)

Comment 5

5 years ago
Created attachment 738200 [details] [diff] [review]
JSMutableHandleId; 1of1; v0
Attachment #738200 - Flags: review?(jcoppeard)
(Reporter)

Comment 6

5 years ago
Created attachment 738201 [details] [diff] [review]
JSMutableHandleScript; 1of1; v0
Attachment #738201 - Flags: review?(jcoppeard)
(Reporter)

Comment 7

5 years ago
Created attachment 738247 [details] [diff] [review]
JSMutableHandleObject; 1of3; v0

Generated with the script:
> find js/src/jsapi-tests/ -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandleObject/g'
> find js/ -name "*.py" -or -name "*.h" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandleObject/g'
> find js/ -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/MutableHandleObject/g'
Attachment #738247 - Flags: review?(jcoppeard)
(Reporter)

Comment 8

5 years ago
Created attachment 738250 [details] [diff] [review]
JSMutableHandleObject; 2of3; v0

Remove JSMutableHandleObject typedef manually rather than complicating the script. Will fold before pushing.
Attachment #738250 - Flags: review?(jcoppeard)
(Reporter)

Comment 9

5 years ago
Created attachment 738251 [details] [diff] [review]
JSMutableHandleObject; 3of3; v0

This is the browser portion of the name change. It was generated with the following command:
> find . -name "*.py" -or -name "*.h" -or -name "*.cpp" | xargs sed -i 's/JSMutableHandleObject/JS::MutableHandle<JSObject*>/g'
Attachment #738251 - Flags: review?(bzbarsky)
Comment on attachment 738251 [details] [diff] [review]
JSMutableHandleObject; 3of3; v0

r=me
Attachment #738251 - Flags: review?(bzbarsky) → review+

Updated

5 years ago
Attachment #738075 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738076 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738186 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738187 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738200 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738201 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738247 - Flags: review?(jcoppeard) → review+

Updated

5 years ago
Attachment #738250 - Flags: review?(jcoppeard) → review+

Comment 12

5 years ago
Any more to do here?
You need to log in before you can comment on or make changes to this bug.