860084 - Clone history from the parent tab when opening a link in a new tab

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Frank Yan (:fryn)]

To make the overlay (and app bar) back button work most effectively, we probably need to stop including about:start as a tab history item (making about:start work like about:newtab does now on Firefox desktop) and change cmd_back to display the start page when there are no more previous tab history items left.

This is closely tied to "zooming out" the tab into a thumbnail inside the Start Page when switching to the Start Page.

Comment 2

[Frank Yan (:fryn)]

Attachment: patch (copy history from opener tab when creating tab)

Our code is so much easier to understand than tabbrowser.xml :)

Comment 3

[Frank Yan (:fryn)]

Comment on attachment 750178 [details] [diff] [review]
patch (copy history from opener tab when creating tab)

Review of attachment 750178 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser.js
@@ +1578,5 @@
>    },
>  
> +  _copyHistoryFrom: function _copyHistoryFrom(tab) {
> +    let otherHistory = tab._chromeTab.linkedBrowser._webNavigation.sessionHistory;
> +    let history = this._chromeTab.linkedBrowser._webNavigation.sessionHistory;

Oh, ._chromeTab.linkedBrowser can just be ._browser

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 750178 [details] [diff] [review]
patch (copy history from opener tab when creating tab)

I'm guessing this will be a little confusing because of how it differs from other browsers (including Firefox on all other platforms), but let's try it out and see how it feels.

Comment 5

[Frank Yan (:fryn)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70bd47701e63

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/70bd47701e63