860159 - Check for any missing IID changes with changed interfaces for Fx22(Aurora)

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[bhavana bajaj [:bajaj]]

We need to find missing IID changes for :

a) Before the merge happened when Fx 22 was still on nightly(m-c)
b) Check for any missing IID changes when Fx22 was on aurora

Scott, last time I tried steps in https://bugzilla.mozilla.org/show_bug.cgi?id=851302#c1 was running into issues.

Can you please help identify the interfaces here and we can do the needed co-ordination to create and follow-up on Bugs that need's IID revved.

Comment 1

[bhavana bajaj [:bajaj]]

Scott, a quick check if the automation is ready yet else we may need your help again to find the interfaces and I or akeybl can file bugs do the out reach to make sure the needed IID's are revved.

Comment 2

[Scott Johnson (:jwir3)]

(In reply to bhavana bajaj [:bajaj] from comment #1)
> Scott, a quick check if the automation is ready yet else we may need your
> help again to find the interfaces and I or akeybl can file bugs do the out
> reach to make sure the needed IID's are revved.

Hi Bhavana:

No, sorry, the automated tool is pretty much in the same state as for the last release. I really thought I would have time to work on it this cycle, but, alas, I have not.

Comment 3

[bhavana bajaj [:bajaj]]

in terms of timeline,our merge day for next release is May13 and we should be getting any issues out of this resolved by then

Comment 4

[Scott Johnson (:jwir3)]

(In reply to bhavana bajaj [:bajaj] from comment #3)
> in terms of timeline,our merge day for next release is May13 and we should
> be getting any issues out of this resolved by then

Bhavana:

I'm not sure I understood that last comment. I doubt that the automated tool will be ready by that date.  I can, however, assist you in finding the IIDs that may have changed in a given release.

Comment 5

[bhavana bajaj [:bajaj]]

(In reply to Scott Johnson (:jwir3) from comment #2)
> (In reply to bhavana bajaj [:bajaj] from comment #1)
> > Scott, a quick check if the automation is ready yet else we may need your
> > help again to find the interfaces and I or akeybl can file bugs do the out
> > reach to make sure the needed IID's are revved.
> 
> Hi Bhavana:
> 
> No, sorry, the automated tool is pretty much in the same state as for the
> last release. I really thought I would have time to work on it this cycle,
> but, alas, I have not.

Thanks for the update Scott..hrm, looks like we'll have to do the semi-automated mechanism here to make sure nothing accidentally slips through and come-out as top-crashers :-/ Thanks in advance for your help :)

Comment 6

[Scott Johnson (:jwir3)]

I spoke with Bhavana last week about checking IIDs for binary compatibility for Firefox 22 (currently aurora, soon to be beta). The changes I found made to .idl files are attached in a diff file.

I believe the following interfaces will need to have IIDs revved:

nsIB2GKeyboard
nsIWebSocketChannel
nsINavHistoryResultNode
IUIABridge
IUIAElement

Note that, at least the first of these is B2G-only, so probably isn't a priority. The others I don't know about.

I am still finishing up quirks with an automated way of checking this, but it's better than it was. If you would like me to demonstrate it to you (it comes up with a few false positives, but, to my knowledge, it errs on the side of detecting an IID change that probably isn't necessary - i.e. the "safe" side), I would be happy to do so.

Comment 7

[Scott Johnson (:jwir3)]

Attachment: diff file for idl changes from fx22 since uplift to aurora

Comment 8

[Alex Keybl [:akeybl]]

* nsIB2GKeyboard caused by bug 844716
** don't plan to file - no binary compatibility issues here 
* nsIWebSocketChannel caused by bug 849364
** Filed bug 870579
* nsINavHistoryResultNode caused by bug 561450
** Filed bug 870581
* IUIABridge & IUIAElement caused by bug 843456

Comment 9

[Scott Johnson (:jwir3)]

(In reply to Alex Keybl [:akeybl] from comment #8)
> * nsIB2GKeyboard caused by bug 844716
> ** don't plan to file - no binary compatibility issues here 

I would probably still file a bug. At some point, we are going to have binary compatibility issues with B2G, and it's probably better to get in the habit of revving IIDs every time the interface changes, anyway.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 11

[Andrew McCreight [:mccr8]]

It looks like this was an old meta bug that has served its purpose.