860184 - Automatically use the x86-64 NDK toolchain when possible

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Automatically use the x86-64 NDK toolchain when possible

Comment 2

[Mike Hommey [:glandium]]

Adrian, can you test this patch works for you (that is, whether it allows you to build without adding --with-android-toolchain to your mozconfig)

Comment 3

[Adrian Tamas (:AdrianT)]

I no longer get a request to setup the toolchain variable with this patch. Will also add an update when the build is completed

Comment 4

[Adrian Tamas (:AdrianT)]

Build was successful using NDK r8e and no option for the toolchain in mozconfig

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 735641 [details] [diff] [review]
Automatically use the x86-64 NDK toolchain when possible

Review of attachment 735641 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/autoconf/android.m4
@@ +85,5 @@
> +                ;;
> +            x86_64)
> +                android_toolchain="$android_ndk"/toolchains/$target_name/prebuilt/$kernel_name-x86_64
> +                if ! test -d "$android_toolchain" ; then
> +                    android_toolchain="$android_ndk"/toolchains/$target_name/prebuilt/$kernel_name-x86

Kind of sucks to repeat this path twice, but it's not the end of the world.

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b8b3f270ee6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b8b3f270ee6