860225 - Restrict en-US reviewer's keyword permissions to en-US articles

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Scoobidiver (away)]

Bug 837851 added a keyword permission to https://support.mozilla.org/groups/knowledge-base-reviewers for any articles including non en-US articles.
This prevents localizers with review permissions from reviewing new translations (not in a permission meaning) when contributors choose wrong keywords (new contributors don't know https://support.mozilla.org/kb/when-and-how-to-use-keywords). See https://support.mozilla.org/fr/localization/unreviewed

Restrict the keyword permission to en-US articles.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Thanks for filing Scoobidiver! CCing Verdi to make sure he is OK with this.

Comment 2

[Ricky Rosario [:rrosario, :r1cky]]

Made this a 1pter because it should be a pretty easy change to an if statement somewhere.

Comment 3

[Rosana Ardila]

This sounds like a good idea Scoobi, thanks for filing this! Let's wait for Michael's feedback.

Comment 4

[Verdi [:verdi] Best to slack me]

I think this sounds good. Would localized articles have their own keywords and permission for editing them or would they just not have keywords?

Comment 5

[Scoobidiver (away)]

(In reply to Verdi [:verdi] from comment #4)
> Would localized articles have their own keywords and permission for editing them or
> would they just not have keywords?
As stated in bug 837851, locales are less polluted by contributors changing only (and wrongly) keywords. Indeed the base of contributors is more stable so it applies only to new contributors from time to time, which is currently the case for French. For me, the keyword field for localized articles should be like any other fields in the Content section as it was before bug 837851.

Comment 6

[Verdi [:verdi] Best to slack me]

Ok got it. Let's do this!

Comment 7

[Kadir Topal [:atopal]]

Unfortunately that doesn't answer the question. If we do this, we have to add the permission to locale leaders, otherwise localizers won't be able to add any keywords.

Comment 8

[Kadir Topal [:atopal]]

Okay, so we'll have this assigned to locale leaders/reviewers so only them would be able to change that in their localized articles. bug 720226

Comment 9

[Scoobidiver (away)]

(In reply to Kadir Topal [:atopal] from comment #7)
> Unfortunately that doesn't answer the question.
It does. If you restrict the en-US reviewer permission to en-US articles, it means that non en-US articles don't need permission to have their keyword changed.

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1275

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d578d2593b6205b46f97c9b545e19e55c3e130c6

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.