860230 - Pressing "More" when user added all shortcuts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

After a user added all shortcuts from the More menu, pressing it will make the Loading screen stuck.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 735693 [details]
Patch - redirect to github PR

Some questions:

* Is it reproducible in v1.0.1?

If yes -> Ask for tef?

* Is it reproducible in v1-train?

If yes -> Ask for leo?

* Please ask for review to Stas because you added a new literal, although it is a minor change :)

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

it's reproducible in both- should I change to leo? or can I add more than one blocking?

and which Stas? what's his email address?

Comment 4

[Cristian Rodriguez (:crdlc)]

IMHO it is not a blocker, it is more a nice to have. Ask for tef? If finally they decide that it is not a blocker, we could ask for approval v1. done til now, thanks Evyatar

Comment 5

[Evyatar 'Tron' Amitay (everything.me)]

note that it means that if a user adds ALL the shortcuts from the More menu and then pressed More again- the app will stuck on the Loading screen with no other indication, and the user will have to press Cancel. I think it's pretty critical.

but we'll let them decide :) thanks!

Comment 6

[Daniel Coloma:dcoloma]

I cannot reproduce it in v1.0.1. What happens to me is that I when all the categories are added the "More" option disappears. I have tried in English and Spanish. By the way, in Spanish I have noticed that some categories are not translated yet to Spanish when changing the language:

 STR:

  0 - Configure device in English
  1 - Add all the categories to e.me (the more icon disappears)
  2 - Switch device language to Spanish
  3 - Some categories are still shown in English in e.me grid, e.g. Nightlife, Productivity, shoes...
  
  Please note that if I remove those categories and add them again they are in Spanish both in the category list and in the grid. Can you please check what is going on before I open a follow-up a bug?

Comment 7

[Evyatar 'Tron' Amitay (everything.me)]

1) the more button not showing: that's actually a separate bug! notice if you pan to the landing page, and then back to e.me, you'll be able to swipe down and see the More button. this was also fixed in this patch.

2) This is actually a complicated case, but it's working by design (hard to believe, I know). What's happening is we have a basic set of categories translated in the locale files, so those will be translated every time. However, additional shortcuts (like Nightlife, for example) will only be translated if you add them in the specific language.

At the time this was coded, we decided (along with Product) that this is sufficient.

That said- if you feel it's an important case that needs addressing, feel free to open a bug about it and assign it to me, and I'll see how it can be fixed and work towards pushing it forward.

Comment 8

[Staś Małolepszy :stas]

Comment on attachment 735693 [details]
Patch - redirect to github PR

r=me for landing on master and v1-train.

v1.0.1 is string frozen and I don't think we should add another string.  If this bug is tef+'ed, please needinfo me again before landing on v1.0.1.

Comment 9

[Daniel Coloma:dcoloma]

Based on comments above I'd suggest we just take this for v1.1. It seems like a cornercase and the device is still usable.

Comment 11

[Evyatar 'Tron' Amitay (everything.me)]

just checking the pulse on this- it hasn't even been merged into master, are you guys waiting on me to do it, or....?

Comment 12

[Evyatar 'Tron' Amitay (everything.me)]

merged
57ff1b0d55a0b3a6edb64e18c56d181d9b93cecf

https://github.com/mozilla-b2g/gaia/commit/57ff1b0d55a0b3a6edb64e18c56d181d9b93cecf


please note that there's a new string ("No Shortcuts to add")- who do I talk to to get this translated?

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 57ff1b0d55a0b3a6edb64e18c56d181d9b93cecf
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[Evyatar 'Tron' Amitay (everything.me)]

yeap, minor conflict resolved.

merged into v1-train
0923389973e7fb6b2d6f335cc7318223e91ad4f1

https://github.com/mozilla-b2g/gaia/commit/0923389973e7fb6b2d6f335cc7318223e91ad4f1