860263 - The email input on "get mozilla updates" form is missing a required attribute

Status: RESOLVED FIXED

(www.mozilla.org :: Newsletters, defect, P3)

Description

[Isac Lagerblad (:icaaq)]

1. Press Cmd+N to open a new browser window, then type eg. http://www.mozilla.org in the address bar and press Enter
2. Check the "I’m okay with you handling this info as you explain in your Privacy Policy" checkbox
3. Press the "sign me up" button

Then the form is submitted which it shouldn't. A required attribute and a aria-required="true" attribute should be added to the email input field.

Comment 1

[Mike Alexis [:malexis]]

I think this is a known issue that is covered in the upcoming bedrock port. Dan/Jess can you confirm?

Comment 2

[Jessilyn Davis]

Hey - the signup form on mozilla.org is integrated with the Foundation's Email newsletter/Blue State Digital. Dan and I are not working on this page/integration and it's not a known issue that I know of.

There does need to be an error thrown with a prompt to enter your email address on this page.

The newsletter signup forms that Dan/I'm working on can be found here:
https://www.mozilla.org/firefox/fx/
https://www.mozilla.org/newsletter

And errors do show if you do not have an email address entered. See screenshots.

FWIW, when the form on https://www.mozilla.org is submitted w/o an email address, I'm taken to the Foundation's site signup form: https://sendto.mozilla.org/page/s/sign-up-for-mozilla  where the error is shown that the email address is required. See screenshot.

Comment 3

[Jessilyn Davis]

Attachment: /firefox error prompt

Comment 4

[Jessilyn Davis]

Attachment: /newsletter error prompt

Comment 5

[Jessilyn Davis]

Attachment: mozilla.org -> foundation error post submitting form w/o email address

Comment 6

[Dan Poirier [:dpoirier]]

I agree this isn't something that will be fixed by the work we're currently doing, so it needs to be fixed separately.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/3bc4cf1da11b7b84d7f674079c3bfd708b439e64
Bug 860263  Adds required and aria-required="true" to email input
Also adds visually hidden labels on email and country

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://www.allizom.org/en-US/

Comment 9

[Dan Poirier [:dpoirier]]

Looks good on https://www.mozilla.org/en-US/