860276 - engines whose URLs specify a template that includes a query string in addition to <Param>s fail to properly construct the submission URI

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Mike Kaply [:mkaply]]

I added DuckDuckGo from https://duckduckgo.com/

It's search syntax is:

https://duckduckgo.com/?q=test

I then made this call:

Services.search.getEngineByName("DuckDuckGo").addParam("fluffy", "bunny", null);

When I executed a search, it was:

https://duckduckgo.com/?q=testfluffy=bunny

Subsequent addParams worked properly (Adding &fluffy=bunny).

So adding the very first parameter if there is not already a parameter doesn't seem to work.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

See http://hg.mozilla.org/mozilla-central/annotate/ee5ca214e87c/netwerk/base/public/nsIBrowserSearchService.idl#l54. 

But this isn't really a problem with addParam, it's a fundamental issue with engines whose URL templates specify a query string in addition to specifying <Param>s, e.g.:

<SearchPlugin xmlns="http://www.mozilla.org/2006/browser/search/">
<ShortName>Example Search</ShortName>
<Url type="text/html" method="GET" template="https://www.example.com/?search={searchTerms}">
  <Param name="otherparam" value="othervalue"/>
</Url>
</SearchPlugin>

The fix is to improve the logic in SRCH_EURL_getSubmission that does the string munging (the "url += dataString" part needs to consider the presence of existing query string parameters).

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 3

[Mike Kaply [:mkaply]]

Legacy Extensions.