860288 - The partner customization packaged apps in https://github.com/telefonicaid/firefoxos-gaia-spain and https://github.com/telefonicaid/firefoxos-gaia-latam are not specifying etag headers correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Jason Smith [:jsmith]]

The etag headers specified for any packaged app in https://github.com/telefonicaid/firefoxos-gaia-latam and https://github.com/telefonicaid/firefoxos-gaia-spain does not contain the proper syntax of having a \" at the beginning and end of every etag, so right now, none of the etags will work. We need to fix this in order to prevent users from getting a massive wave of app updates upon starting to use their phone.

Comment 1

[Jason Smith [:jsmith]]

Yurenju - Can you take a look at this?

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi Jason,

for metadata without etag, I knew this problem and asked Karen providing urls for app update and Karen said those apps will not upgrade via marketplace. needinfo karen for more detail.

for metadata with etag but incorrectly, would you give a example for that?

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

please reference bug 817044 comment 35.

Comment 4

[Julien Wajsberg [:julienw]]

Yuren, if the actual ETag value has quotes, then the quotes must be in the value defined in the metadata json file.

For example, for the youtube application, I take the manifest URL https://marketplace.firefox.com/app/9a46c4e6-0f8b-40cb-a770-11ea1b7fda20/manifest.webapp (defined in metadata.json) :

  $ curl -I https://marketplace.firefox.com/app/9a46c4e6-0f8b-40cb-a770-11ea1b7fda20/manifest.webapp
  HTTP/1.1 200 OK
  Server: gunicorn/0.15.0
  Vary: X-Requested-With, Accept-Language, Cookie, X-Mobile, User-Agent
  X-Backend-Server: web6.addons.phx1.mozilla.com
  Content-Type: application/x-web-app-manifest+json
  Strict-Transport-Security: max-age=2592000
  Date: Thu, 11 Apr 2013 06:55:53 GMT
  Transfer-Encoding: chunked
  ETag: "c0216f1ee14450d5af4ae5c90e25bfee"
  Via: Moz-pp-zlb08
  Connection: Keep-Alive
  Set-Cookie: lang="en-US\054"; Path=/
  Set-Cookie: region=us; Path=/

You can see the ETag header actually has quotes. This means that these quotes must be in the value defined in metadata.json. Currently it is "c0216f1ee14450d5af4ae5c90e25bfee" whereas it should be "\"c0216f1ee14450d5af4ae5c90e25bfee\"": the quotes are really part of the value !

Is it clearer ?

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Oh I trimed that in my script, Thank you Julien, it's clearer for me :D

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I opened a bug for that in my github project.
https://github.com/yurenju/gaia-preload-app/issues/3

but we still need to update metadata in telefonicaid repositories.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Fixed it on gaia-preload-app and I will make new version for telefonica repository on bug 864617.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Fixed on bug 864617