860397 - WebRTC unit-test pilot-error crash [@nr_turn_client_allocate]

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Christoph Diehl [:posidron]]

Attachment: callstack

This crash occurs while running the unit tests for TURN.

[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from TurnClient
[ RUN      ] TurnClient.Allocate
media/mtransport/test/turn_unittest.cpp:116: Failure
Value of: r
  Actual: 7
Expected: 0
ASAN:SIGSEGV

It seems like it caused by using a domain name as TURN_SERVER_ADDRESS instead of an IP address.

export TURN_SERVER_ADDRESS=localhost

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

This looks to be a testcase crash, not in our nightly user crash data, so not clear what we'd track this bug for. Please renominate if there's a user-facing issue here.

Comment 2

[Eric Rescorla (:ekr)]

I believe lsblakk is correct here. It seems to me that this
is just the unit test continuing after the failure to convert
the hostname.

Comment 3

[Maire Reavy [:mreavy]]

Jib, Can you fix the unit test and then coordinate with ekr to see if anything else needs to be fixed/addressed?

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: turn_unittest checks that TURN_SERVER_ADDRESS is IP#s not FQDN

Hopefully this patch removes future pilot error.

Note that I haven't changed the unit-test to "fail nicely", as I don't see the point in doing that.

Comment 5

[Jacek Caban]

https://hg.mozilla.org/integration/mozilla-inbound/rev/26eb52ade0ee

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/26eb52ade0ee