SetCacheAsFile returns successful when talking to https

VERIFIED FIXED in mozilla0.9.2

Status

()

Core
Networking: HTTP
P1
blocker
VERIFIED FIXED
17 years ago
6 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
mozilla0.9.2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
SetCacheAsFile on http protocol returns successful even when talking to https. 
This function must return a failure code if cacheing as a file is illegal.  

The three requirements that http should enforce before return success are (a) a 
disk cache present, (b) not using https, and (c) there are no response headers 
that ask for nonpersistance.
(Assignee)

Updated

17 years ago
Severity: normal → blocker
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla0.9.2
(Assignee)

Updated

17 years ago
Blocks: 54689
(Assignee)

Comment 1

17 years ago
Created attachment 38562 [details] [diff] [review]
Fixes most of the problem.
(Assignee)

Comment 2

17 years ago
Darin, this fixes most of the problem for me.  As so long as this caching flag 
is being set in the right places, this should work.  It works for the https 
case which is my blocker.

Can I get you to sr this patch as is?  

Comment 3

17 years ago
sr=darin

Comment 4

17 years ago
r=gagan. asa can we get some a= love here?
a=blizzard on behalf of drivers for the trunk
(Assignee)

Updated

17 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

17 years ago
thanks.  fixed checked in:

Checking in nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  
nsHttpChannel.cpp
new revision: 1.24; previous revision: 1.23
done

Comment 7

15 years ago
Verified.
Status: RESOLVED → VERIFIED
QA Contact: benc → junruh
You need to log in before you can comment on or make changes to this bug.