86041 - SetCacheAsFile returns successful when talking to https

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Doug Turner (:dougt)]

SetCacheAsFile on http protocol returns successful even when talking to https. 
This function must return a failure code if cacheing as a file is illegal.  

The three requirements that http should enforce before return success are (a) a 
disk cache present, (b) not using https, and (c) there are no response headers 
that ask for nonpersistance.

Comment 1

[Doug Turner (:dougt)]

Attachment: Fixes most of the problem.

Comment 2

[Doug Turner (:dougt)]

Darin, this fixes most of the problem for me.  As so long as this caching flag 
is being set in the right places, this should work.  It works for the https 
case which is my blocker.

Can I get you to sr this patch as is?  

Comment 3

[Darin Fisher]

sr=darin

Comment 4

[Gagan]

r=gagan. asa can we get some a= love here?

Comment 5

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for the trunk

Comment 6

[Doug Turner (:dougt)]

thanks.  fixed checked in:

Checking in nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  
nsHttpChannel.cpp
new revision: 1.24; previous revision: 1.23
done

Comment 7

[John Unruh]

Verified.