860470 - Labels on the partners page is hidden

Status: RESOLVED WONTFIX

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Isac Lagerblad (:icaaq)]

1. Press Cmd+N to open a new browser window, then type https://www.mozilla.org/en-US/firefox/partners/ in the address bar and press Enter
2. Press "Partner with us" button
3. See that the labels for the input fields are hidden. Only placeholder attributes are used.

There are two problems with this.
1. The labels are hidden with display:none; which means that eg. screenreaders wont announce them.
2. placeholder attributes are used as labels when it's clearly stated in the html5 spec that this can harm usability and accessibility:

"Use of the placeholder attribute as a replacement for a label can reduce the accessibility and usability of the control for a range of users including older users and users with cognitive, mobility, fine motor skill or vision impairments. While the hint given by the control's label is shown at all times, the short hint given in the placeholder attribute is only shown before the user enters a value. Furthermore, placeholder text may be mistaken for a pre-filled value, and as commonly implemented the default color of the placeholder text provides insufficient contrast and the lack of a separate visible label reduces the size of the hit region available for setting focus on the control.
> http://www.w3.org/html/wg/drafts/html/master/forms.html#the-placeholder-attribute

I would suggest to use visible labels (there is plenty of room for that here) and if needed a placeholder attribute that hints the user what you want them to enter in the inputfield.

Comment 1

[Jennifer Bertsch [:jbertsch]]

Sounds good.  Can you do a pull request?

Comment 2

[Jonathan Petto [:jpetto]]

A sub-task of bug 859427? Might be best to take care of these as they pop up, but an overall sweep/update is probably in order at some point.

Comment 3

[Jennifer Bertsch [:jbertsch]]

I like that idea, Jon.

Comment 4

[Kohei Yoshino [:kohei]]

The form on /firefox/partners/ has been removed in favor of https://mobilepartners.mozilla.org/