Status
()
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Tracking
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(3 attachments)
|
3.88 KB,
patch
|
evilpie
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
|
1.74 KB,
patch
|
evilpie
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
|
2.77 KB,
patch
|
evilpie
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
Let's get a start on reducing the dom/bindings noise.
|
(Assignee) | |
Comment 1•6 years ago
|
||
Created attachment 735957 [details] [diff] [review] part 1. Root WebIDL dictionary ParseJSON. smaug
Attachment #735957 -
Flags: review?(evilpies)
Attachment #735957 -
Flags: review?(bugs)
|
|
(Assignee) | |
Updated•6 years ago
|
||
Assignee: nobody → bzbarsky
|
|
(Assignee) | |
Comment 2•6 years ago
|
||
Created attachment 735960 [details] [diff] [review] part 2. Root WebIDL dictionary ToObject.
Attachment #735960 -
Flags: review?(evilpies)
Attachment #735960 -
Flags: review?(bugs)
|
|
(Assignee) | |
Comment 3•6 years ago
|
||
Created attachment 735961 [details] [diff] [review] part 3. Root ErrorResult::ThrowJSException.
Attachment #735961 -
Flags: review?(evilpies)
Attachment #735961 -
Flags: review?(bugs)
|
|
(Assignee) | |
Updated•6 years ago
|
||
Whiteboard: [need review]
|
||
Comment 4•6 years ago
|
||
Comment on attachment 735957 [details] [diff] [review] part 1. Root WebIDL dictionary ParseJSON. smaug Review of attachment 735957 [details] [diff] [review]: ----------------------------------------------------------------- Uhh this pattern returning *cx is quite funny! Maybe<Rooted<Value>> is only used when and defined and everything lives on the stack, so this should be okay. ::: dom/bindings/Codegen.py @@ +6818,5 @@ > (" bool Init(const nsAString& aJSON)\n" > " {\n" > " mozilla::Maybe<JSAutoRequest> ar;\n" > " mozilla::Maybe<JSAutoCompartment> ac;\n" > + " Maybe< JS::Rooted<JS::Value> > json;\n" Drop the mozilla:: for the others? Is that first space needed?
Attachment #735957 -
Flags: review?(evilpies) → review+
|
|
||
Updated•6 years ago
|
||
Attachment #735960 -
Flags: review?(evilpies) → review+
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 735961 [details] [diff] [review] part 3. Root ErrorResult::ThrowJSException. Review of attachment 735961 [details] [diff] [review]: ----------------------------------------------------------------- Easy enough as well!
Attachment #735961 -
Flags: review?(evilpies) → review+
|
|
(Assignee) | |
Comment 6•6 years ago
|
||
> Drop the mozilla:: for the others? Done. > Is that first space needed? No, but I prefer the symmetry, and the last space _is_ needed.
|
||
Comment 7•6 years ago
|
||
Comment on attachment 735957 [details] [diff] [review] part 1. Root WebIDL dictionary ParseJSON. smaug Drop the space after <
|
|
||
Updated•6 years ago
|
||
Attachment #735957 -
Flags: review?(bugs) → review+
|
|
||
Updated•6 years ago
|
||
Attachment #735960 -
Flags: review?(bugs) → review+
|
|
||
Updated•6 years ago
|
||
Attachment #735961 -
Flags: review?(bugs) → review+
|
|
(Assignee) | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa9337d57ed https://hg.mozilla.org/integration/mozilla-inbound/rev/df6981fad6a2 https://hg.mozilla.org/integration/mozilla-inbound/rev/fc32e1f944e3
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla23
|
||
Comment 9•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dfa9337d57ed https://hg.mozilla.org/mozilla-central/rev/df6981fad6a2 https://hg.mozilla.org/mozilla-central/rev/fc32e1f944e3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•