86066 - "Mark All Read" is disabled when it shouldn't be

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[[e-mail]]

The line

return(MailAreaHasFocus() && IsFolderSelected());

was needed by the case cmd_MarkAllRead: but was accidentally deleted when the
case cmd_DownloadFlagged: was moved.

CCing as per CVS log, but couldn't identify r=bhuvan so CCing ducarroz instead :-)

Comment 1

[[e-mail]]

Attachment: proposed patch

Comment 2

[Håkan Waara]

Good catch. r=hwaara (unless this removal was intentional).

CC (bhuvan) racham as per summary.

Comment 3

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 4

[racham]

r=bhuvan

Comment 5

[Christopher Blizzard (:blizzard)]

Do you guys need approval on this?  If so, mail [e-mail] ( I'm not
cc'ed on the bug. )

This free advertisement was brought to you buy today's sponsor, Red Hat, Inc.

Comment 6

[(not reading, please use [e-mail] instead)]

I forgot that bienvenu's on vacation.

I'll drive it in.

Comment 7

[(not reading, please use [e-mail] instead)]

updating summary

Comment 8

[(not reading, please use [e-mail] instead)]

update url

Comment 9

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

sorry for the delay.  

I'm sure this fixes some dups, too.  (I'm thinking about "access key for mark 
all read doesn't work".)

Comment 11

[grylchan]

Commercial Builds
2001-06-21-09-trunk win nt 4.0
2001-06-21-08-trunk/ mac 9.0.4
2001-06-22-11-trunk/ linux 2.2, red hat 7.0

In Messenger:
Message|Mark|Mark all Read is enabled when you
select a folder in a Imap, pop, webmail, or newsgroup account.
It is disabled if you select the server.

And it works as expected also.

Marking as verified.

Comment 12

[Koike Kazuhiko]

*** Bug 73471 has been marked as a duplicate of this bug. ***

Comment 13

[Koike Kazuhiko]

*** Bug 85928 has been marked as a duplicate of this bug. ***

Comment 14

[Jacek Piskozub]

I do not see bug 73471 (duped against this one) fixed. WindowsME 2001062204
build on WindowsME, alternative 3-pane and View Unread+Threaded selected.

It seems tome this one is about a recent problem and 73471 started when the new
mailnews code landed. Reopening 73471