860680 - [SMS][MMS] Include new layout in SMS/MMS App

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Visual design 1.

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: Visual design 2.

Comment 3

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

New visuals will be attached to this bug asap due to there are some tweaks based on the first proposal.

Comment 4

[Borja Salguero [:borjasalguero]]

Attachment: New visual 1

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: New visual 2

Comment 6

[Borja Salguero [:borjasalguero]]

Comment on attachment 739031 [details]
Pull Request

Review needed for the new Strings

Comment 7

[Staś Małolepszy :stas]

Which branch is this supposed to land on?  The blocking flags tell me nothing.

If master and/or v1-train, no l10n review is needed.

That said, the "recipientRemoval" string has an unnecessary quote at the end: 

+recipientRemoval   = Do you want to remove {{recipient}} from the recipients list?'

Comment 8

[Borja Salguero [:borjasalguero]]

Comment on attachment 739031 [details]
Pull Request

Ready to be reviewed! Tests added as well.

Comment 9

[Julien Wajsberg [:julienw]]

afaik this should be leo+ right ?

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking since this affects multi-recipient messaging.

Comment 11

[Julien Wajsberg [:julienw]]

reviewed in github

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 739031 [details]
Pull Request

Looking at Julien's comments on the patch, this isn't ready for l10n review yet.

Julien, it'd be helpful for others that look at the patch if you could flip a review flag on the attachment here in either direction, too.

Comment 13

[Julien Wajsberg [:julienw]]

Pike> oki, I will do that now, if there are multiple reviewers

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 739031 [details]
Pull Request

r=me

this is not perfect but good enough so let's enable other people work.

Comment 15

[Borja Salguero [:borjasalguero]]

Here there are some stuff to do, and It will be complete through 861227 & 837994.

Comment 16

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/60cdc0740438986c4fe502eb9c0822ce14248ef7

https://github.com/borjasalguero/gaia/commit/482008ef3e9501afea1580dc7c1094333622eb83

Comment 17

[James Lal [:lightsofapollo]]

Merge conflicts cannot uplift to v1-train

Comment 18

[Julien Wajsberg [:julienw]]

will resolve conflicts

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 60cdc0740438986c4fe502eb9c0822ce14248ef7
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 20

[Julien Wajsberg [:julienw]]

v1-train: 8980fddbd44e1c61482d6d339eacf7b3e95910d0