Closed Bug 860723 Opened 7 years ago Closed 7 years ago

Custom fields are shown twice in report axis selectors

Categories

(Bugzilla :: Reporting/Charting, defect, trivial)

4.2.5
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: pami.ketolainen, Assigned: pami.ketolainen)

References

Details

Attachments

(1 file)

Attached patch v1Splinter Review
The template code for axis field select boxes first adds the fields listed in 'report_columns' and then the custom fields from 'custom_fields'. But the 'report_columns' list comes from Bugzilla::Search::REPORT_COLUMNS -> Bugzilla::Search::COLUMNS, which already contains the custom fields.

Attached is a patch to remove the duplication.
Attachment #736253 - Flags: review?(LpSolit)
Assignee: charting → pami.ketolainen
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 4.2
Version: unspecified → 4.2.5
Comment on attachment 736253 [details] [diff] [review]
v1

r=LpSolit
Attachment #736253 - Flags: review?(LpSolit) → review+
Depends on: 545766
Flags: approval4.4+
Flags: approval4.2+
Flags: approval+
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8608.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8542.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8203.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.