Custom fields are shown twice in report axis selectors

RESOLVED FIXED in Bugzilla 4.2

Status

()

Bugzilla
Reporting/Charting
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Pami Ketolainen, Assigned: Pami Ketolainen)

Tracking

4.2.5
Bugzilla 4.2
Bug Flags:
approval +
approval4.4 +
approval4.2 +

Details

Attachments

(1 attachment)

v1
1.33 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
Created attachment 736253 [details] [diff] [review]
v1

The template code for axis field select boxes first adds the fields listed in 'report_columns' and then the custom fields from 'custom_fields'. But the 'report_columns' list comes from Bugzilla::Search::REPORT_COLUMNS -> Bugzilla::Search::COLUMNS, which already contains the custom fields.

Attached is a patch to remove the duplication.
(Assignee)

Updated

4 years ago
Attachment #736253 - Flags: review?(LpSolit)

Updated

4 years ago
Assignee: charting → pami.ketolainen
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 4.2
Version: unspecified → 4.2.5

Comment 1

4 years ago
Comment on attachment 736253 [details] [diff] [review]
v1

r=LpSolit
Attachment #736253 - Flags: review?(LpSolit) → review+

Updated

4 years ago
Depends on: 545766
Flags: approval4.4+
Flags: approval4.2+
Flags: approval+

Comment 2

4 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8608.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8542.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8203.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.