Last Comment Bug 860723 - Custom fields are shown twice in report axis selectors
: Custom fields are shown twice in report axis selectors
Status: RESOLVED FIXED
:
Product: Bugzilla
Classification: Server Software
Component: Reporting/Charting (show other bugs)
: 4.2.5
: All All
: -- trivial (vote)
: Bugzilla 4.2
Assigned To: Pami Ketolainen
: default-qa
:
Mentors:
Depends on: 545766
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-11 05:27 PDT by Pami Ketolainen
Modified: 2013-04-11 06:18 PDT (History)
0 users
LpSolit: approval+
LpSolit: approval4.4+
LpSolit: approval4.2+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
v1 (1.33 KB, patch)
2013-04-11 05:27 PDT, Pami Ketolainen
LpSolit: review+
Details | Diff | Splinter Review

Description Pami Ketolainen 2013-04-11 05:27:36 PDT
Created attachment 736253 [details] [diff] [review]
v1

The template code for axis field select boxes first adds the fields listed in 'report_columns' and then the custom fields from 'custom_fields'. But the 'report_columns' list comes from Bugzilla::Search::REPORT_COLUMNS -> Bugzilla::Search::COLUMNS, which already contains the custom fields.

Attached is a patch to remove the duplication.
Comment 1 Frédéric Buclin 2013-04-11 06:13:32 PDT
Comment on attachment 736253 [details] [diff] [review]
v1

r=LpSolit
Comment 2 Frédéric Buclin 2013-04-11 06:18:41 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8608.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8542.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified query.cgi
modified template/en/default/search/search-report-select.html.tmpl
Committed revision 8203.

Note You need to log in before you can comment on or make changes to this bug.