860754 - Malay input.m.o missing, locale code `ms`

Status: RESOLVED FIXED

(Input Graveyard :: Frontend, defect, P1)

Description

[arky [:arky]]

There is input for Malay language. This breaks the input feedback system on our Firefox Malay aurora builds. 

https://input.mozilla.org/ms

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in https://github.com/mozilla/fjord/commit/507d3acbe0b71b003177ec89b144c565b384406b

That's the code changes required.

However, there's no ms locale in Verbatim, so it's not seeing this as a valid locale. That needs to get added.

Working on that now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Milos: We need to add a new locale to input. I think it's something I can do with a merge. When's a good time for you to do this?

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Milos: We need to add a new locale to input. I think it's something I can do with a merge. When's a good time for you to do this?

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1.

Comment 5

[Milos Dinic [:Milos]]

Will, actually, there is Malay in Verbatim, right at https://localize.mozilla.org/ms. What you probably wanted to say is that they didn't opt-in for translating input in Verbatim, which is true.

I just added Input in the list of Malay projects in Verbatim: https://localize.mozilla.org/ms/input/ . Please let me know if there's anything else I can help you guys with.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just did "svn up" in the locale/ directory and there's still no "ms" so it seems like there's still something to do.

I think it's something I can do with a merge. When's a good time for you to do this?

Comment 7

[Milos Dinic [:Milos]]

Well, that's just a concequence of working on weekends - I forgot to commit that to SVN. I fixed that in r115230.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Awesome--that works great! Thanks Milos!

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

We don't do deployments on weekends, so I'll push this out on Monday.

Comment 10

[Will Kahn-Greene [:willkg] ET needinfo? me]

I was sick Monday and Tuesday. :(

I just pushed all the changes and new locale strings to input on stage and prod. Going to https://input.mozilla.org/ms/ works correctly now. People should be able to leave feedback in that locale, too.

Marking this as FIXED.