Closed
Bug 860777
Opened 12 years ago
Closed 12 years ago
GC: Root XPCWrappedJSClass.cpp and WrapperFactory.cpp
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(2 files)
21.98 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
15.50 KB,
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Blocks: ExactRootingBrowser
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #736358 -
Flags: review?(bobbyholley+bmo)
Assignee | ||
Comment 2•12 years ago
|
||
Rooting in the JS engine wrapping callbacks will follow in a later bug.
Attachment #736360 -
Flags: review?(bobbyholley+bmo)
Comment 3•12 years ago
|
||
Comment on attachment 736358 [details] [diff] [review]
1 - Rooting in XPCWrappedJSClass.cpp
Review of attachment 736358 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/src/XPCWrappedJSClass.cpp
@@ +22,5 @@
>
> // the value of this variable is never used - we use its address as a sentinel
> static uint32_t zero_methods_descriptor;
>
> +bool AutoScriptEvaluate::StartEvaluating(JS::HandleObject scope, JSErrorReporter errorReporter)
using namespace js, please
@@ +197,5 @@
> }
>
> JSObject*
> nsXPCWrappedJSClass::CallQueryInterfaceOnJSObject(JSContext* cx,
> + JSObject* jsobj_,
per terrence's comment, it sounds like we want objArg
Attachment #736358 -
Flags: review?(bobbyholley+bmo) → review+
Comment 4•12 years ago
|
||
Comment on attachment 736360 [details] [diff] [review]
2 - Rooting in WrapperFactory.cpp
Review of attachment 736360 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/xpconnect/wrappers/WrapperFactory.cpp
@@ +60,5 @@
> return xpc_UnmarkGrayObject(scope->mWaiverWrapperMap->Find(obj));
> }
>
> JSObject *
> +WrapperFactory::CreateXrayWaiver(JSContext *cx, JS::HandleObject obj)
using namespace JS
Attachment #736360 -
Flags: review?(bobbyholley+bmo) → review+
Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4eef306e0156
https://hg.mozilla.org/mozilla-central/rev/954c25a05631
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•