GC: Root XPCWrappedJSClass.cpp and WrapperFactory.cpp

RESOLVED FIXED in mozilla23

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

Trunk
mozilla23
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

No description provided.
Attachment #736358 - Flags: review?(bobbyholley+bmo)
Rooting in the JS engine wrapping callbacks will follow in a later bug.
Attachment #736360 - Flags: review?(bobbyholley+bmo)
Comment on attachment 736358 [details] [diff] [review]
1 - Rooting in XPCWrappedJSClass.cpp

Review of attachment 736358 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCWrappedJSClass.cpp
@@ +22,5 @@
>  
>  // the value of this variable is never used - we use its address as a sentinel
>  static uint32_t zero_methods_descriptor;
>  
> +bool AutoScriptEvaluate::StartEvaluating(JS::HandleObject scope, JSErrorReporter errorReporter)

using namespace js, please

@@ +197,5 @@
>  }
>  
>  JSObject*
>  nsXPCWrappedJSClass::CallQueryInterfaceOnJSObject(JSContext* cx,
> +                                                  JSObject* jsobj_,

per terrence's comment, it sounds like we want objArg
Attachment #736358 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 736360 [details] [diff] [review]
2 - Rooting in WrapperFactory.cpp

Review of attachment 736360 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/WrapperFactory.cpp
@@ +60,5 @@
>      return xpc_UnmarkGrayObject(scope->mWaiverWrapperMap->Find(obj));
>  }
>  
>  JSObject *
> +WrapperFactory::CreateXrayWaiver(JSContext *cx, JS::HandleObject obj)

using namespace JS
Attachment #736360 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/4eef306e0156
https://hg.mozilla.org/mozilla-central/rev/954c25a05631
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.