860777 - GC: Root XPCWrappedJSClass.cpp and WrapperFactory.cpp

Status: RESOLVED FIXED

Comment 1

[Jon Coppeard (:jonco)]

Attachment: 1 - Rooting in XPCWrappedJSClass.cpp

Comment 2

[Jon Coppeard (:jonco)]

Attachment: 2 - Rooting in WrapperFactory.cpp

Rooting in the JS engine wrapping callbacks will follow in a later bug.

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 736358 [details] [diff] [review]
1 - Rooting in XPCWrappedJSClass.cpp

Review of attachment 736358 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/src/XPCWrappedJSClass.cpp
@@ +22,5 @@
>  
>  // the value of this variable is never used - we use its address as a sentinel
>  static uint32_t zero_methods_descriptor;
>  
> +bool AutoScriptEvaluate::StartEvaluating(JS::HandleObject scope, JSErrorReporter errorReporter)

using namespace js, please

@@ +197,5 @@
>  }
>  
>  JSObject*
>  nsXPCWrappedJSClass::CallQueryInterfaceOnJSObject(JSContext* cx,
> +                                                  JSObject* jsobj_,

per terrence's comment, it sounds like we want objArg

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 736360 [details] [diff] [review]
2 - Rooting in WrapperFactory.cpp

Review of attachment 736360 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/xpconnect/wrappers/WrapperFactory.cpp
@@ +60,5 @@
>      return xpc_UnmarkGrayObject(scope->mWaiverWrapperMap->Find(obj));
>  }
>  
>  JSObject *
> +WrapperFactory::CreateXrayWaiver(JSContext *cx, JS::HandleObject obj)

using namespace JS

Comment 5

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4eef306e0156
https://hg.mozilla.org/integration/mozilla-inbound/rev/954c25a05631

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4eef306e0156
https://hg.mozilla.org/mozilla-central/rev/954c25a05631