Closed Bug 860777 Opened 12 years ago Closed 12 years ago

GC: Root XPCWrappedJSClass.cpp and WrapperFactory.cpp

Categories

(Core :: XPConnect, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(2 files)

No description provided.
Attachment #736358 - Flags: review?(bobbyholley+bmo)
Rooting in the JS engine wrapping callbacks will follow in a later bug.
Attachment #736360 - Flags: review?(bobbyholley+bmo)
Comment on attachment 736358 [details] [diff] [review] 1 - Rooting in XPCWrappedJSClass.cpp Review of attachment 736358 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/src/XPCWrappedJSClass.cpp @@ +22,5 @@ > > // the value of this variable is never used - we use its address as a sentinel > static uint32_t zero_methods_descriptor; > > +bool AutoScriptEvaluate::StartEvaluating(JS::HandleObject scope, JSErrorReporter errorReporter) using namespace js, please @@ +197,5 @@ > } > > JSObject* > nsXPCWrappedJSClass::CallQueryInterfaceOnJSObject(JSContext* cx, > + JSObject* jsobj_, per terrence's comment, it sounds like we want objArg
Attachment #736358 - Flags: review?(bobbyholley+bmo) → review+
Comment on attachment 736360 [details] [diff] [review] 2 - Rooting in WrapperFactory.cpp Review of attachment 736360 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/xpconnect/wrappers/WrapperFactory.cpp @@ +60,5 @@ > return xpc_UnmarkGrayObject(scope->mWaiverWrapperMap->Find(obj)); > } > > JSObject * > +WrapperFactory::CreateXrayWaiver(JSContext *cx, JS::HandleObject obj) using namespace JS
Attachment #736360 - Flags: review?(bobbyholley+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: