Closed Bug 860779 Opened 7 years ago Closed 7 years ago

Two-finger horizontal swipe disabled as of 2013-04-11 mozilla-central nightly

Categories

(Core :: Widget: Cocoa, defect, major)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: smichaud, Assigned: spohl)

References

Details

Attachments

(1 file, 2 obsolete files)

We recently landed support for swipe animation in bug 678392.  But this support is turned off by default, and doing this (very unfortunately) seems to turn off our support for swiping altogether.

We need to scramble to find a way to turn off swipe animation without turning off support for swiping altogether.
Assignee: nobody → spohl.mozilla.bugs
Blocks: 678392
Attached patch Patch (obsolete) — Splinter Review
Attachment #736368 - Flags: review?(smichaud)
Attached patch Patch (obsolete) — Splinter Review
Corrected misspelling in commit message, removed trailing white space and added comment to HSA_Init for the scenario when no snapshots are being taken/stored.
Attachment #736368 - Attachment is obsolete: true
Attachment #736368 - Flags: review?(smichaud)
Attachment #736374 - Flags: review?(smichaud)
Attached patch PatchSplinter Review
No, really remove trailing white space now.
Attachment #736374 - Attachment is obsolete: true
Attachment #736374 - Flags: review?(smichaud)
Attachment #736376 - Flags: review?(smichaud)
Comment on attachment 736376 [details] [diff] [review]
Patch

Looks fine to me.

And I tested it briefly on OS X 10.7.5, with browser.snapshots.limit set to '0' (the default) and to '5'.  I saw no problems:  You get swiping without animation with the former setting, and swiping with animation with the latter setting.
Attachment #736376 - Flags: review?(smichaud) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c2943880a742
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.