Two-finger horizontal swipe disabled as of 2013-04-11 mozilla-central nightly

RESOLVED FIXED in mozilla23

Status

()

Core
Widget: Cocoa
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smichaud, Assigned: spohl)

Tracking

Trunk
mozilla23
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We recently landed support for swipe animation in bug 678392.  But this support is turned off by default, and doing this (very unfortunately) seems to turn off our support for swiping altogether.

We need to scramble to find a way to turn off swipe animation without turning off support for swiping altogether.
(Reporter)

Updated

5 years ago
Assignee: nobody → spohl.mozilla.bugs
Blocks: 678392
(Assignee)

Comment 1

5 years ago
Created attachment 736368 [details] [diff] [review]
Patch
Attachment #736368 - Flags: review?(smichaud)
(Assignee)

Comment 2

5 years ago
Created attachment 736374 [details] [diff] [review]
Patch

Corrected misspelling in commit message, removed trailing white space and added comment to HSA_Init for the scenario when no snapshots are being taken/stored.
Attachment #736368 - Attachment is obsolete: true
Attachment #736368 - Flags: review?(smichaud)
Attachment #736374 - Flags: review?(smichaud)
(Assignee)

Comment 3

5 years ago
Created attachment 736376 [details] [diff] [review]
Patch

No, really remove trailing white space now.
Attachment #736374 - Attachment is obsolete: true
Attachment #736374 - Flags: review?(smichaud)
Attachment #736376 - Flags: review?(smichaud)
(Reporter)

Comment 4

5 years ago
Comment on attachment 736376 [details] [diff] [review]
Patch

Looks fine to me.

And I tested it briefly on OS X 10.7.5, with browser.snapshots.limit set to '0' (the default) and to '5'.  I saw no problems:  You get swiping without animation with the former setting, and swiping with animation with the latter setting.
Attachment #736376 - Flags: review?(smichaud) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c2943880a742
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.