860894 - Renaming/moving an IDL file shouldn't require a clobber

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Reuben Morais [:reuben]]

I tried to land bug 856358 and discovered that renaming an IDL file requires a clobber. This shouldn't be necessary.

Comment 1

[Gregory Szorc [:gps]]

I don't suppose you know why this requires a clobber, do you? If it's in IDL building itself, it should get fixed by bug 850380. If it's in some downstream system, we might be hosed until more things are more intelligent.

Comment 2

[Reuben Morais [:reuben]]

All I know is that renaming dom/interfaces/contacts/nsIDOMContactProperties.idl to nsIContactProperties.idl caused this failure:

make[6]: *** No rule to make target `/builds/slave/m-in-osx64_g-00000000000000000/build/dom/interfaces/contacts/nsIDOMContactProperties.idl', needed by `_xpidlgen/nsIDOMContactManager.xpt'.  Stop.
make[6]: *** Waiting for unfinished jobs....

Comment 3

[Gregory Szorc [:gps]]

Well, that's interesting. I would think the missing .idl would have been removed by mddepend.pl. This is most weird.

I'm optimistic this will go away in bug 850380. Let's leave open to track just in case.

Comment 4

[(not currently active) Ted Mielczarek]

I think this is just fallout from bug 462463:
http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1357
http://mxr.mozilla.org/mozilla-central/source/xpcom/idl-parser/typelib.py#296

The patch there didn't change typelib.py to write out extra dep lines for the input IDL files, and we're not running mddepend.pl anymore which used to fix that.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Fix typelib.py after bug 462463

Comment 6

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/63d6c868147e

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/63d6c868147e