860952 - PeerConnection mochi test failures should indicate the calling site

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P4)

Description

[Adam Roach [:abr]]

Although most tests are pretty good about indicating what is about to happen,
it is still possible for the shared failure callback to be ambiguous about
exactly what failed. Ideally, such failures would be tagged with the filename
and line number from which the callback originated.

Comment 1

[Adam Roach [:abr]]

Attachment: Add error site information to unexpectedCallbackAndFinish callback

This patch turns unexpectedCallbackAndFinish into a function that generates
a callback function with the calling site embedded in it. It does so by passing
in a new Error object, from which the source filename and line number can be
read.

Comment 2

[Jason Smith [:jsmith]]

Comment on attachment 736523 [details] [diff] [review]
Add error site information to unexpectedCallbackAndFinish callback

Review of attachment 736523 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/tests/mochitest/head.js
@@ +157,5 @@
> +    if (aObj && aObj.name && aObj.message) {
> +      ok(false, "Unexpected error callback from " + where + " with name = '" +
> +                aObj.name + "', message = '" + aObj.message + "'");
> +    } else {
> +       ok(false, "Unexpected error callback from " + where + " with " + aObj);

Nit - indentation is off here

Comment 3

[Adam Roach [:abr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10f5180c8d25

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/10f5180c8d25