860991 - Firefox customize personas preview is broken

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Chris More [:cmore]]

Now that getpersonas.com has been migrated to AMO, this page is broken:

http://www.mozilla.org/en-US/firefox/customize/

Code:

https://github.com/mozilla/bedrock/blob/master/apps/firefox/templates/firefox/customize.html

https://github.com/mozilla/bedrock/blob/master/media/js/firefox/customize.js

the iframe was pointing to:

http://www.getpersonas.com/en-US/external/mozilla/persona-preview-frame

We should ask the AMO team to take the old page that was on getpersonas.com and put it somewhere on AMO so that we can update our link.

Comment 1

[Wil Clouser [:clouserw]]

bug 795138 asked that all personas content was removed from moz.org.  If it's something you want to retain we should figure out a better solution than what was there (which was a hardcoded set of personas in a hardcoded width x height iframe).

Comment 4

[Chris More [:cmore]]

(In reply to Wil Clouser [:clouserw] from comment #1)
> bug 795138 asked that all personas content was removed from moz.org.  If
> it's something you want to retain we should figure out a better solution
> than what was there (which was a hardcoded set of personas in a hardcoded
> width x height iframe).

I opened bug 860996 because we have more instances of getpersonas.com that need to be resolved. As the iframe, what other way can we do persona previews without an iframe when Firefox only had getpersonas.com and AMO white listed? What other kind of magic would preview the personas in the browser chrome without an iframe while on mozilla.org?

Comment 5

[Wil Clouser [:clouserw]]

If you want to be able to preview, yeah, we'll need to do the iframe.  I was hoping for something that was usable everywhere rather than just hardcoded for moz.org.  Like, a widget I guess, where you get to say "My favorite personas, 2 wide, 3 tall" and it spits out something.

If restoring the iframe is a P1 for you though, we may have to cut some corners on that.

Comment 6

[Chris More [:cmore]]

(In reply to Wil Clouser [:clouserw] from comment #5)
> If you want to be able to preview, yeah, we'll need to do the iframe.  I was
> hoping for something that was usable everywhere rather than just hardcoded
> for moz.org.  Like, a widget I guess, where you get to say "My favorite
> personas, 2 wide, 3 tall" and it spits out something.
> 
> If restoring the iframe is a P1 for you though, we may have to cut some
> corners on that.

Leaving the page broke until the new Firefox family website in another few months doesn't seem ideal, so here are the options given the page gets 45k pageviews daily:

1) Restore the iframe page

2) Remove the section all together

3) Keep the section, add static assets on the page, and just link to AMO. i.e. no fancy preview.

Comment 7

[Wil Clouser [:clouserw]]

It looks like an easy *temporary* solution here is to change the URL you are iframeing to http://static.getpersonas.com/en-US/external/mozilla/

It'll be a bit before we decommission static.g.c but we should make plans to replace it.

Does that work for you?

Comment 8

[Chris More [:cmore]]

PR: https://github.com/mozilla/bedrock/pull/773

Comment 9

[Chris More [:cmore]]

(In reply to Wil Clouser [:clouserw] from comment #7)
> It looks like an easy *temporary* solution here is to change the URL you are
> iframeing to http://static.getpersonas.com/en-US/external/mozilla/
> 
> It'll be a bit before we decommission static.g.c but we should make plans to
> replace it.
> 
> Does that work for you?

Yeah, let's do that until we decide on what to do. 

Jbertsch: Is this page included in the Q2 refresh work or can we come up with a better solution so it doesn't break again when static.getpersonas.com goes away?

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ed45fba5760aa674a608c372916bc14a65d76f0b
Bug 860991 - Firefox persona preview broke

https://github.com/mozilla/bedrock/commit/556d537eaf9f359b2ee59232f46da560b42253dc
Merge pull request #773 from chrismore/patch-5

Bug 860991 - Firefox persona preview broke

Comment 11

[Chris More [:cmore]]

PR for template: https://github.com/mozilla/bedrock/pull/774

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e7a4d559c46057339627f78e877476d2440f2212
Bug 860991 - Firefox persona preview broke

https://github.com/mozilla/bedrock/commit/3f8645bb5e4a87be07d3e00076de41616e22ee03
Merge pull request #774 from chrismore/patch-6

Bug 860991 - Firefox persona preview broke

Comment 13

[Chris More [:cmore]]

It appears that the html page on static.getpersonas.com was slightly different than what was on www.getpersonas.com OR maybe something else is going on.

On this page:

http://static.getpersonas.com/en-US/external/mozilla/

There is a single image/preview on a 5th row when there should only be 4 previews and it is making a scroll bar show up on the page where the iframe is implemented.

Comment 14

[Chris More [:cmore]]

PR to change iframe height: https://github.com/mozilla/bedrock/pull/775

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b85ed4ab271188f9403b3f4a9d5185de7a96b163
Bug 860991 - Firefox persona preview broke

https://github.com/mozilla/bedrock/commit/72d48ac2a787037722f0b4ad74dfea7087cd7e7b
Merge pull request #775 from chrismore/patch-7

Bug 860991 - Firefox persona preview broke

Comment 16

[Jennifer Bertsch [:jbertsch]]

Cmore:  We haven't finished defining the list of pages impacted by the firefox family work.

I'd like to go with static assets and a link to the themes page until we finish defining the firefox family work and know what is going to happen to /customize.

Comment 17

[raymond [:retornam] (inactive)]

This is fixed on release Firefox 20  but broken on Nightly 23.0a1 (2013-04-11)  due to insecure content warnings, we decided to push the fix to prod until we can come up with a better solution for the insecure content warnings.

http://www.mozilla.org/en-US/firefox/customize/

Comment 18

[Laura Forrest]

(In reply to jbertsch from comment #16)
> Cmore:  We haven't finished defining the list of pages impacted by the
> firefox family work.
> 
> I'd like to go with static assets and a link to the themes page until we
> finish defining the firefox family work and know what is going to happen to
> /customize.

This is fine for the short-term, but having this rollover preview functionality is really one of the most powerful user experiences we've got that shows off this Firefox feature superbly. I'd hate for it to be forgotten about. 

It's still working for me, but in the case that this wasn't actually fixed, let's be sure to add it back in wherever we talk about Themes in the very near future.

Comment 19

[Chris More [:cmore]]

 
> It's still working for me, but in the case that this wasn't actually fixed,
> let's be sure to add it back in wherever we talk about Themes in the very
> near future.

I fixed the page today by pointing the preview page a copy of the old getpersonas.com website, which will not be around much long. Clouserw wants to come up with a better solution for the future on AMO. Let's revisit this page sooner than later so this doesn't break again when static.getpersonas.com goes away for good.