860998 - Remove useless getSpecialFolderKey assignment

Status: RESOLVED WONTFIX

(Toolkit :: Downloads API, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Noticed this while triaging (bug 293187). getSpecialFolderKey (http://dxr.mozilla.org/search?tree=mozilla-central&q=getSpecialFolderKey&redirect=true) doesn't appear to be doing anything useful. It can probably be removed, unless I'm missing something.

Comment 1

[Manish [:manishkk]]

Need to remove this only?

https://searchfox.org/mozilla-central/search?q=getSpecialFolderKey&case=false&regexp=false&path=

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Yep!

Comment 3

[Manish [:manishkk]]

Attachment: Bug 860998- Remove useless getSpecialFolderKey assignment

Comment 4

[Manish [:manishkk]]

this line should exist?
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js#44

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Bah, I just realized that comm-central uses this member. :(

https://dxr.mozilla.org/comm-central/rev/2a29ee0adb310b54a6a2df72034953fed8f2b043/comm/mail/components/preferences/downloads.js#79

See my review. I don't think we should review it unless we need to, to avoid screwing over comm-central needlessly.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

(In reply to Manish [:manishkk] from comment #4)

this line should exist?
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js#44

Hey, :dimi, do you know if we can get rid of the references to this file?

Comment 7

[Dimi Lee [:dimi]]

(In reply to Mike Conley (:mconley) (:⚙️) from comment #6)

(In reply to Manish [:manishkk] from comment #4)

this line should exist?
https://searchfox.org/mozilla-central/source/toolkit/components/url-classifier/tests/unit/head_urlclassifier.js#44

Hey, :dimi, do you know if we can get rid of the references to this file?
yes.
This looks like a duplicate comment of Bug 723153 Comment 16

Comment 8

[Manish [:manishkk]]

yes, Sorry!
It's a duplicate comment, mistakenly happened.