Closed Bug 861017 Opened 7 years ago Closed 7 years ago

wiki.m.o page turned into a redirect with no way back to the original page

Categories

(Websites :: wiki.mozilla.org, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: luke, Unassigned)

Details

Clicking on this page:
  https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style
redirects to this page:
  https://wiki.mozilla.org/JavaScript:SpiderMonkey:C_Coding_Style
Clicking "What links here" in the left toolbar confirms that indeed the original page is a redirect.

This help article:
  http://www.mediawiki.org/wiki/Help:Redirects#Viewing_a_redirect
seems to indicate that, when the redirect occurs, there is a link back to the original page, but no such link seems to be present on the destination page.  Because of this, we seem to have totally lost our C++ style guide page with no way to get it back.

Is there anything about our installation or templates that could be hiding this link back to the original page?

Thank you
Once this is fixed, I need to update the rules on header #includes to for https://bugzilla.mozilla.org/show_bug.cgi?id=634839#c27.
> we seem to have totally lost our C++ style guide
> page with no way to get it back.

This is really bad.  We've lost critical documentation.  Can anyone help?
Sheppy, perhaps you might know some people who can drive this forward?
Flags: needinfo?(eshepherd)
I suspect this is a problem with MediaWiki.  Still, I can't reproduce it on recent versions (see https://en.wikipedia.org/wiki/Special:WhatLinksHere/User:MarkAHershberger/SpiderMonkey:C_Coding_Style for my attempt to reproduce this).

So maybe it is a bug that has been fixed since 1.19.

What was the original content of the page?
(In reply to Mark A. Hershberger (hexmode) from comment #4)
> So maybe it is a bug that has been fixed since 1.19.

I'm not sure what you were linking to.  From a logged-out session, I can still reproduce the problem in comment 0.

> What was the original content of the page?

The C++ style guideline.  (The page you see is the C style guideline.)  (Yes we should merge them, but first we need to get the content back :)
(In reply to Luke Wagner [:luke] from comment #5)
> (In reply to Mark A. Hershberger (hexmode) from comment #4)
> > So maybe it is a bug that has been fixed since 1.19.
> 
> I'm not sure what you were linking to.  From a logged-out session, I can
> still reproduce the problem in comment 0.

I was linking to my attempt to reproduce this on Wikipedia which runs a later version of MediaWiki.  The version on wikimo is 1.19 -- the LTS version of MediaWiki -- but the Wikipedia page (https://en.wikipedia.org/w/index.php?title=User:MarkAHershberger/SpiderMonkey:C%2B%2B_Coding_Style&redirect=no) is accessible.  I just tried to create a similar page on Wikimo (https://wiki.mozilla.org/User:MarkAHershberger/C%2B%2B_Coding_Style) and it did end up on (https://wiki.mozilla.org/User:MarkAHershberger/C_Coding_Style).  So, yes, this is a bug.  I need to do a little more research, though.
Here is your data:
https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style?title=JavaScript:SpiderMonkey:C%2B%2B_Coding_Style

It seems like this is a problem with parsing the page title which shows up only when the page title is in the URL, as opposed to the "title" parameter.

Here is the history, which does not show an edit to make the page a redirect:
https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style?title=JavaScript:SpiderMonkey:C%2B%2B_Coding_Style&action=history

Gerv
Thanks!  I wonder if the C%2B%2B is at fault?

Either way, we should probably roll this page into the C page.
I wonder if + characters are no longer allowed in page titles? The recent upgrade might have changed this.

Could someone with server access check $wgLegalTitleChars in LocalSettings.php and in includes/DefaultSettings?

Reference: http://www.mediawiki.org/wiki/Manual:$wgLegalTitleChars 

MediaWiki documentation also says of the + character in page titles: "Enabled by default, but doesn't work with path to query rewrite rules, corrupted by apache." So that might be another thing to look at.
Note that https://wiki.mozilla.org/index.php?title=JavaScript:SpiderMonkey:C%2B%2B_Coding_Style&action=edit also has the page available.

I tried going to /C%2b%2b_style on a 1.19 wiki and ended up on /C_Style.  Will file a bug.
(In reply to Christie Koehler [:ckoehler] from comment #9)
> I wonder if + characters are no longer allowed in page titles? The recent
> upgrade might have changed this.

I'm pretty sure this is a bug in this version that has been fixed in later versions.  I've seen it on other 1.19 wikis.

> Could someone with server access check $wgLegalTitleChars in
> LocalSettings.php and in includes/DefaultSettings?

I went over the LocalSettings.php file pretty closely when helped upgrade the wiki.  I don't recall seeing that setting.
(In reply to Mark A. Hershberger (hexmode) from comment #11)
> (In reply to Christie Koehler [:ckoehler] from comment #9)
> > I wonder if + characters are no longer allowed in page titles? The recent
> > upgrade might have changed this.
> 
> I'm pretty sure this is a bug in this version that has been fixed in later
> versions.  I've seen it on other 1.19 wikis.

Interesting. I'm not seeing it in another wiki I use that's 1.19.1.

> I went over the LocalSettings.php file pretty closely when helped upgrade
> the wiki.  I don't recall seeing that setting.

Did you look at includes/DefaultSettings.php? The + character was added in 1.18.3 and I feel like we upgraded from an version older than that. 

I also think it's worth looking at the apache rewrite rules, given the note in the documentation about path to query rules being corrupted.
(In reply to Christie Koehler [:ckoehler] from comment #12)
> I also think it's worth looking at the apache rewrite rules, given the note
> in the documentation about path to query rules being corrupted.

That is a good point.  The only rule in my 1.19 wiki that would have affect this is: RewriteRule ^(.*)$ /index.php/?title=$1 [L,QSA]

I changed it to "RewriteRule ^(.*)$ /index.php/$1 [L,QSA]" and set $wgUsePathInfo to true in LocalSettings and now the http://alexandermen.com/C%2b%2b_style page works on my 1.19 wiki.
I accessed the page contents via
https://wiki.mozilla.org/JavaScript:SpiderMonkey:C%2B%2B_Coding_Style?title=JavaScript:SpiderMonkey:C%2B%2B_Coding_Style, and I copied those contents into https://wiki.mozilla.org/JavaScript:SpiderMonkey:Coding_Style, and made the former redirect to the latter.

https://wiki.mozilla.org/JavaScript:SpiderMonkey:C_Coding_Style appears to be an alias for https://wiki.mozilla.org/JavaScript:SpiderMonkey:Coding_Style (note the "C_" which distinguishes them);  if I edit either the changes show up in both.  Not sure how that happens;  I'd be happy to remove the C_Coding_Style version if possible.

Anyway, the original problem (we couldn't see our C++ code guidelines) has been fixed, to I'll resolve this.  Thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(eshepherd)
note someone still needs to fix the LocalSettings.php and .htaccess
You need to log in before you can comment on or make changes to this bug.