[CustomizeUI] The browser bookmarks for customization doesn't work

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: askeing, Assigned: gasolin)

Tracking

unspecified
All
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 fixed)

Details

(Reporter)

Description

5 years ago
### ENV:
Device inari
Gaia:     63890fe9845c13613e9de6017f742a28ea4ee24d
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473

### STR:
1. follow the steps of https://wiki.mozilla.org/B2G/MarketCustomizations#Customization_Overview, download gaia-distribution-sample.zip file.
2. unzip zip file then copy into gaia/distribution folder.
3. make clean && make production

### Expected:
There are two bookmarks in browser.

### Actually:
No bookmarks.
nominating to tef+ becuase this is a part of customization
blocking-b2g: --- → tef?
(Assignee)

Comment 2

5 years ago
Askeing,
Assignee: nobody → gasolin
(Assignee)

Comment 3

5 years ago
After test with Askeing, its only occur in v1.0.1, but 1.1 works fine.

It because gaia-distribution-sample.zip file use new bookmark.json format

to let v1.0.1 support this customization.

uplift Bug 835350 to v1.0.1 will resolve this issue
b08c3de547f93f58c5797f60240039e154d07832

If need to uplift Bug 835350, gaia-spain bookmark should be changed to match the new format.
Flags: needinfo?(yurenju.mozilla)
(Assignee)

Comment 4

5 years ago
current sample on #Customization_Overview is for version > v1.1

Update and add v1.0.1 sample on 
https://wiki.mozilla.org/B2G/MarketCustomizations#Customization_Overview
Yuren, what do you think is the best approach:

1/ Uplift bug 835350 so that the same json file works for all the versions
2/ Change the json file adapting it for v1.0.1
blocking-b2g: tef? → tef+
I prefer first option because it can keep all version use same configration file and it's better for long term.
Flags: needinfo?(yurenju.mozilla)

Updated

5 years ago
Depends on: 835350
(In reply to Yuren Ju [:yurenju] from comment #6)
> I prefer first option because it can keep all version use same configration
> file and it's better for long term.

Agreed, mark as tef+ so we can have same mechanism in all versions.

Comment 8

5 years ago
Do we have any update about the bug?
Thanks.
Flags: needinfo?(gasolin)
QA Contact: atsai
(Assignee)

Comment 9

5 years ago
:jford just land bug 835350 to v1.0.1: 0852fcbfc33495a35f122796dfd25ba86f11ffe5
And I've update the customization doc.

Yuren, please remind to update the custom bookmark syntax in customer repo. 

thanks.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(gasolin) → needinfo?(yurenju.mozilla)
Resolution: --- → FIXED
filed issues to panther's repositories
Flags: needinfo?(yurenju.mozilla)

Updated

5 years ago
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected

Updated

5 years ago
status-b2g18: affected → fixed
status-b2g18-v1.0.1: affected → fixed
(Reporter)

Comment 11

5 years ago
inari

v1.0.1
gaia 2543428e16a5f1a716bd3e8c646119acba12b524

v1-train
gaia 502653c27d86acbb82e170ccf4d226999458ca84

Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.